Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug output for broker truncated #2272

Closed
J-Gras opened this issue Jul 14, 2022 · 0 comments · Fixed by #2312
Closed

Debug output for broker truncated #2272

J-Gras opened this issue Jul 14, 2022 · 0 comments · Fixed by #2312
Labels
Area: Broker good first issue A good place to get started working with Zeek. Type: Bug 🐛 Unexpected behavior or output.

Comments

@J-Gras
Copy link
Collaborator

J-Gras commented Jul 14, 2022

Looking at the broker debug output, it seems some of the output for logging is truncated.

Steps to reproduce:

  1. In testing/btest/broker/remote_log.zeek add -B broker to the invocations of Zeek in lines 5 & 6:
# @TEST-EXEC: btest-bg-run recv "zeek -B broker -b ../recv.zeek >recv.out"
# @TEST-EXEC: btest-bg-run send "zeek -B broker -b ../send.zeek >send.out"
  1. Run the test and keep tmp files using btest -t broker/remote_log.zeek.
  2. Find the debug log in .tmp/broker.remote_log/recv/debug.log containing lines that look truncated, e.g.:
1657789876.326786/1657789876.326870 [broker] Received log-write: (1, 3, (Broker::LOG, Log::WRITER_ASCII, broker,
@timwoj timwoj added good first issue A good place to get started working with Zeek. Type: Bug 🐛 Unexpected behavior or output. Area: Broker labels Jul 19, 2022
@AmazingPP AmazingPP mentioned this issue Aug 2, 2022
Merged
awelzel added a commit to zeek/broker that referenced this issue Aug 4, 2022
@awelzel
Hex escape broker::to_string(data<string>) containing non-ascii chars
824016d 
...trying something as a fix for zeek/zeek#2272 .
@awelzel awelzel mentioned this issue Aug 4, 2022
Closed
awelzel added a commit to zeek/broker that referenced this issue Aug 8, 2022
@awelzel
Hex escape broker::to_string(data<string>) containing non-ascii chars
ae7ac71 
...trying something as a fix for zeek/zeek#2272 .
awelzel added a commit to zeek/broker that referenced this issue Aug 8, 2022
@awelzel
Hex escape broker::to_string(data<string>) containing non-ascii chars
745f541 
...trying something as a fix for zeek/zeek#2272 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Broker good first issue A good place to get started working with Zeek. Type: Bug 🐛 Unexpected behavior or output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use json_escape_utf8 in broker debug output AmazingPP/zeek
2 participants
@timwoj @J-Gras