Sets do not support pattern types.

[0xekez]

Creating a set of patterns

local s: set[pattern] = {/hello/, /goodbye/};

gives an error error in pattern: bad index type (pattern).

This might just be a matter of making a change to the index type checking for tables here.

[jsiwek]

Don't think there's a reason why not not allow it, at least anymore. Likely would also have to update the CompHash.cc code.

[devbali]

Check out this branch: https://github.com/zeek/zeek/tree/topic/dev/patterns-in-sets
I just took the PatternText(), AnywherePatternText() of the Regular Expression Objects and concatenated them to initialize a Hashkey to support single type sets using Patterns.
If this approach is fine I will add btests and open a PR

[jsiwek]

@devbali yes, think you've got the basic idea, with a couple pointers:

• Completing this requires adding support to other CompositeHash methods like SingleValHash, SingleTypeKeySize, and RecoverOneVal
• For the (de)serialization of patterns, you'll probably find that instead of "null-terminated and delimited with a space character", these are probably better to serialize as two "length of string followed by those N bytes" fields. Can look at how plain strings are handled for an example of this.

[devbali]

Just came back to this today. Opened a Pull Request, please take a look after you come back after Christmas.

[jsiwek]

Fixed via #714