Update private networks list #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I was just recently thinking about wanting to robustly identify non-routed subnets. |
ckreibich
approved these changes
Jul 12, 2021
|
I forgot to merge this before 4.1 branched, but I'm planning to get it in before the first RC. |
|
Merged into both master and release/4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing some odd behavior with some v6 space that we use that's reserved for internal use only. This was missing from
Site::private_address_space, and then I realized that many more were missing.This branch updates that list to address space that IANA has reserved for special usage and is marked as NOT being globally routable. This brings what Zeek considers to be "non-public" IP space in line with Chrome, the W3C spec, and Python's ipaddress module.
The data came from:
https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml
https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml
6to4 address ranges are a bit of a special case (and are marked as such by IANA). If the address maps to a public IPv4 address, it CAN technically be globally routed. If the address maps to a private IPv4 address, though, it's equivalent to that address and should not be globally routed. This matches how browsers treat these addresses.
Edit: Previously I thought that 127.0.0.1/8 (local nets) was not included in Zeek, and this was a change, but that was not correct.