Add BiFs to retrieve numeric ID for a given connection and analyzer #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckreibich
force-pushed
the
topic/christian/analyzer-lookup-bifs
branch
2 times, most recently
from
96579b1
to
455e6a2
Compare
vpax
reviewed
May 25, 2024
0xxon
approved these changes
May 29, 2024
This adds a new lookup_connection_analyzer_id() BiF to find a given connection's numeric identifier for a given protocol analyzer (as defined by the underlying Analyzer::id_counter). This enables users to call disable_analyzer(), which requires a numeric analyzer ID, outside of analyzer_confirmation_info and analyzer_violation_info events handlers.
This replaces generic reporter->Error() calls with the builtin-specific variety, which gives better context in the resulting error messages (such as the script and line causing it). Includes corresponding baseline update in one affected btest.
ckreibich
force-pushed
the
topic/christian/analyzer-lookup-bifs
branch
from
455e6a2
to
a599fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
NEWSaddition for the details. This came out of a support thread on Slack, where I realized that as far as I could discern there's not currently a way to alter analyzer activation viadisable_analyzer()at this level.For consistency I've changed the reporter error function called in
disable_analyzer()since it provides better context.