Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Mac git hook does not work #20

Closed
rimbi opened this issue May 29, 2023 · 2 comments · Fixed by #22
Closed

On Mac git hook does not work #20

rimbi opened this issue May 29, 2023 · 2 comments · Fixed by #22
Labels
bug Something isn't working question Further information is requested

Comments

@rimbi
Copy link

rimbi commented May 29, 2023

The hook ends up with the following output:

+ exec
+ gimoji --hook .git/COMMIT_EDITMSG
Error: Custom { kind: Other, error: "Failed to initialize input reader" }
@zeenix
Copy link
Owner

zeenix commented May 29, 2023

Thanks for reporting this. I was wondering about that. Can you check if removing the exec line in the hook file (.git/hooks/prepare-commit-msg) helps?

@zeenix zeenix added bug Something isn't working question Further information is requested labels May 29, 2023
zeenix added a commit that referenced this issue May 29, 2023
@zeenix
🔥 Remove exec line from git hook
862366a 
I copied over that line from the git hook gitmoji-cli installs and still
not sure what it does. I had assumed it's needed but it seems it isn't.

Also it's likely why git hook doesn't work on Mac and Windows (where it
may not work at all still).

Fixes #20.
@zeenix zeenix mentioned this issue May 29, 2023
Merged
@zeenix
Copy link
Owner

zeenix commented May 29, 2023

Thanks for reporting this. I was wondering about that. Can you check if removing the exec line in the hook file (.git/hooks/prepare-commit-msg) helps?

Created #21 as a potential fix.

rimbi pushed a commit to rimbi/gimoji that referenced this issue May 29, 2023
🚩Fix zeenix#20
3919572 
Enables `use-dev-tty` feature in crossterm.
rimbi pushed a commit to rimbi/gimoji that referenced this issue May 29, 2023
🚩Fix zeenix#20
e13a7d7 
Enables `use-dev-tty` feature in crossterm.
rimbi pushed a commit to rimbi/gimoji that referenced this issue May 29, 2023
🚩Fix zeenix#20
593d1fd 
Enables `use-dev-tty` feature in crossterm.
@zeenix zeenix mentioned this issue May 29, 2023
Merged
rimbi pushed a commit to rimbi/gimoji that referenced this issue May 30, 2023
🚩Fix zeenix#20: Fixes git hook problem on mac
c8ef60b 
Enables `use-dev-tty` feature in crossterm.
zeenix pushed a commit to rimbi/gimoji that referenced this issue May 30, 2023
@zeenix
🚩 Enables use-dev-tty feature of crossterm
6e38b0f 
This fixes git hook problem on mac.

Fix zeenix#20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🚩 Enables use-dev-tty feature in crossterm rimbi/gimoji
2 participants
@zeenix @rimbi