Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore CronJob probes #108

Closed
sstarcher opened this issue Apr 24, 2019 · 0 comments · Fixed by #110
Closed

Ignore CronJob probes #108

sstarcher opened this issue Apr 24, 2019 · 0 comments · Fixed by #110

Comments

@sstarcher
Copy link
Contributor

Describe the bug
CronJobs are highly likely to not have a readiness or liveness concept as they are typically not hooked up to a service. It likely makes sense to either ignore them for probes or to have them at a different level or an optional way to disable them.

To Reproduce

Have a cron job without a probe and run kube-score

Expected behavior
Ability to ignore missing cronjob probes
@sstarcher sstarcher mentioned this issue Apr 25, 2019
Merged
bors bot added a commit that referenced this issue Apr 27, 2019
@bors @sstarcher
Merge #110
5680f88 
110: ignore probes on CronJobs and enhance pod checks to be aware of the r… r=zegl a=sstarcher

…oot type that created them

Resolves #108 

Co-authored-by: Shane Starcher <shanestarcher@gmail.com>
@bors bors bot closed this as completed in #110 Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore probes on CronJobs and enhance pod checks to be aware of the r… sstarcher/kube-score
1 participant
@sstarcher