score/apps: fix statefulset selector labels check #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I left some comments about what the existing code is doing over in #336. This PR seems to implement what is now #381 (and #382). I'd be happy to accept this PR if you reworked it so that it doesn't touch the |
euven
force-pushed
the
fix-statefulset-selector-label-check
branch
from
b7bc215
to
b4997b1
Compare
euven
force-pushed
the
fix-statefulset-selector-label-check
branch
from
b4997b1
to
6c674be
Compare
|
Thanks! |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#pod-selector
This fixes #336