Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to change a carousel item if it contains the link in itself. #108

Closed
5 tasks done
dimabory opened this issue Jun 19, 2019 · 0 comments
Closed
5 tasks done
Assignees
Labels
bug Something isn't working

Comments

@dimabory
Copy link
Collaborator

Bug Report

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you check the FAQs to see if that helps you?
  • Are you reporting to the correct repository?
  • Did you perform a search in the issues?

For more information, see the CONTRIBUTING guide.

Versions

0.6.1

Description

Impossible to drag a carousel item if it contains the link itself.

Steps to Reproduce

  1. Open https://precise-ui.io/#/Components/Carousel
  2. Insert the code in the 1-st example:
const { Carousel } = require('precise-ui');

<Carousel infinite>
  <a href="#1" style={{ height: '150px', width: '100%', backgroundColor: '#f3a', display: 'flex', justifyContent: 'center', alignItems: 'center'}}>
    First page
  </a>
  <a href="#2" style={{ height: '200px', width: '90%', backgroundColor: '#43c', display: 'flex', justifyContent: 'center', alignItems: 'center'}}>
    Second page
  </a>
  <a href="#3" style={{ height: '150px', width: '450px', backgroundColor: '#1f2', display: 'flex', justifyContent: 'center', alignItems: 'center'}}>
    Third page
  </a>
</Carousel>
  1. Try to drag the tile.

Expected behavior:

  • Carousel item is changed.

Actual behavior:

  • The page is changed.

Environment details: [any OS, any browser]

Possible Solution

To be clarified...

@dimabory dimabory added the bug Something isn't working label Jun 19, 2019
@dimabory dimabory changed the title Impossible to change a carousel item if it contains the link itself. Impossible to change a carousel item if it contains the link in itself. Jun 19, 2019
@dimabory dimabory self-assigned this Jul 2, 2019
dimabory added a commit to dimabory/precise-ui that referenced this issue Jul 2, 2019
dimabory added a commit that referenced this issue Jul 2, 2019
Resolve #108 issue (make carousel item clickable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant