Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing 'exit' doesn't quit Hyper #1561

Closed
2 tasks done
Jamesking56 opened this issue Feb 20, 2017 · 8 comments
Closed
2 tasks done

Typing 'exit' doesn't quit Hyper #1561

Jamesking56 opened this issue Feb 20, 2017 · 8 comments

Comments

@Jamesking56
Copy link

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: OS X El Capitan (10.11.6)

  • Hyper.app version: 1.2.1 (1.2.1.1528)

  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/Jamesking56/dfa7735174e81e6a7c68025e991da460

  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A

  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

Open up Hyper, type in exit and press enter. Hyper still exists in Dock and is still open. When last window is closed, the app should quit (like other Mac apps do)

@henrikruscon
Copy link
Contributor

Which apps? Not even terminal fully quits.

@Jamesking56
Copy link
Author

Jamesking56 commented Feb 20, 2017 via email

@ppot
Copy link
Contributor

ppot commented Feb 21, 2017

on bash. Typing exit do close the session. If no sessions are open it will close the window.

@sumnermic
Copy link

@Jamesking56 other apps like the Terminal.app itself will upon $ exit only close window, CMD + W. Similar terminal apps like bash, iTerm(2) do not Quit, CMD + Q, but instead only 'close window'.

@matheuss
Copy link
Member

matheuss commented Feb 25, 2017

When last window is closed, the app should quit (like other Mac apps do)

That's false 🤔 No app quits when the last window is closed on MacOS – it's a standard to still leave the app on the Dock when all windows are closed.

@matheuss
Copy link
Member

The app should only quit when the user explicitly tells it to quit – with CMD+Q for example.

@cblecker
Copy link

For anyone following this:
I prefer a terminal workflow to quit when I type "exit" on the last window as well. So I went ahead and created a plugin to do it. Issues/PRs are welcome.
https://github.com/cblecker/hyper-quit

@albinekb
Copy link
Contributor

Great @cblecker! Make sure to add it to the list: https://github.com/bnb/awesome-hyper ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants