Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix copy/paste shortcuts on Windows/Linux πŸŽ‰ #1406

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

matheuss
Copy link
Member

@matheuss matheuss commented Jan 15, 2017

This PR fixes the copy and paste shortcuts for Windows and Linux πŸ•΅οΈ

There was two problems:

  • An active text selection was being cleared when Ctrl was pressed – you couldn't copy anything
  • The hyper-caret was always being focused, even when it was already inserted into the cursor-node. This was preventing both copy and paste shortcuts from working

Closes #1328, #1381, #1394

Copy link
Contributor

@stefanivic stefanivic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! πŸ‘

@lednhatkhanh
Copy link

I think you should release a new build as a fix when this pull had been merged

@prubini87
Copy link

Hi, how can I apply this fix on my currently installed Hyper? I'm having this precise copy/paste issue!

@stefanivic
Copy link
Contributor

@prubini87 you can cherry-pick the commit and build Hyper localy.

@prubini87
Copy link

Ah, kk @stefanivic, thanks for your quick reply! πŸ‘

@aneira92
Copy link

I'm sorry, but am I new to this, any detailed explanation of how to integrate this change into my currently installed Hyper?

@stefanivic
Copy link
Contributor

@aneira92 the only options are to build it localy or to wait for a build that will come out sometimes this week.

For building localy :
git clone https://github.com/zeit/hyper/
cd hyper
git cherry-pick db4b59e
npm i
npm run dist

@aneira92
Copy link

@stefanivic OK thanks.

Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm !

@matheuss matheuss merged commit b4943a0 into master Jan 18, 2017
@matheuss matheuss deleted the fix/copy-paste branch January 18, 2017 15:19
@matheuss
Copy link
Member Author

Thanks everybody πŸ™Œ Will ship it this week πŸ˜„

@wishinghand
Copy link

Did this make it into Hyper? I'm on Windows 10 and Hyper 2 and ctrl-v does not work.

@pevecyan
Copy link

@wishinghand Did you try ctrl + shift + v?

@wishinghand
Copy link

For some reason my mind wasn't seeing the shift part of these commands. Sorry about that. ctrl-shift-c and ctrl-shift-v both work fine.

@lopugit
Copy link

lopugit commented Nov 30, 2018

was this just fixed or? do I have to build manually? on windows and pasting don't work :'(

@lopugit
Copy link

lopugit commented Nov 30, 2018

omg gyazo was capturing the shortcut fml

@fsilva3
Copy link

fsilva3 commented Aug 12, 2019

if you wanna change the default commands, you can set at .hyper.js config:

...
keymaps: {
  "editor:copy": "ctrl+c",
  "editor:paste": "ctrl+v"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants