Disable VSCode type checking #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why? @chabou I don't think turning it off is the correct solution.. |
|
I don't have time to correct these errors (some false positive). I constantly disable it when I create a branch from canary and pay attention to not commit We made an error to accept the previous PR without resolving found errors. Feel free to reactive this type checking with all error resolved and, if possible a Husky hook to prevent errors to be committed. |
|
It might be better to do this either at the user settings level: Or the file level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking was introduced here: #2272
But there are some confusing errors.
If someone wants to re-enable this, please fix errors too