Update xterm to v3.8.0

[chabou]

Some minor compatibility changes:

• No need to use term.charMeasure anymore (and it isn't accessible anymore)
• term.removeAllListeners doesn't exist anymore. Replaced by addDisposableListener()
• css has been updated (specially for column selection)

This PR needs some more testing, but basic usages are OK.

[chabou]

Related to #2697, #2793 and jestjs/jest#6494

[chabou]

Found a problem with paste (OSX/zsh/oh-my-zsh).
Color is inverted but first char is repeated. Here a example of a Ambler paste:

Note: even for next pastes, it will be the same char that will be repeated.

[mrchief]

Sorry for approving the review. I was simply hoping github would block me. It seems this is a new feature? Seems more like a bug to me. Outside folks should not be able to approve PRs arbitrarily. I'll see if I can revert my approval.

Again, my apologies.

[chabou]

No problem @mrchief .

I don't know if there is a setting to prevent this, but I've been able to review PRs in all public repository.
Don't worry: branch protection rules distinguish reviewers and reviewers with write access 😉

[mrchief]

Thanks @chabou. Looks like this is by design. I haven't found a setting either. But, like you said, thankfully, github doesn't count them towards merge unless the reviewer has write access.