Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add div wrappers around window controls svg elements #3392

Merged

Conversation

jakub-chatrny
Copy link
Contributor

Adding div wrapper around svg element allowing change style of window controls easily just by using css.

Reason for PR:

You cant change svg path using css and you can't use :after or :before on element either.

Utilization of PR:

In my plugin hyper-macos-mjv-dark-theme (You can see image in readme)

  • PR is ready to merge

  • PR allows edits from maintainers

  • PR do not make any changes to API

Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change could break some existing plugins but it will be easy to fix them.
The new styling possibilities offered are worth this change.

@chabou
Copy link
Collaborator

chabou commented Jan 6, 2019

Thank you so much for your help @jakub-chatrny 🙏

@chabou chabou changed the title added div wrappers around window controls svg elements Add div wrappers around window controls svg elements Jan 6, 2019
@chabou chabou merged commit a3db367 into vercel:canary Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants