Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper v3 icons #3451

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Hyper v3 icons #3451

merged 2 commits into from
Feb 5, 2019

Conversation

juancampa
Copy link
Contributor

@juancampa juancampa commented Jan 30, 2019

Before: right
After: left

2019-02-04_22-06

@juancampa juancampa added the WIP label Jan 31, 2019
@juancampa
Copy link
Contributor Author

Merging so that we can include this in the next canary with the electron bump. Though it might now show due to CI replacing it with the "canary" icon

@juancampa juancampa merged commit 761d644 into vercel:canary Feb 5, 2019
@Koolstr
Copy link

Koolstr commented Feb 5, 2019

The new icon is not showing in Windows. Or is this new icon for macOS only? It is nicer, so it would be great if we can get it on Windows too.

Alternatively, it might just not be reflecting for me since I am on the Canary/beta build. If this is the cause, any chance we can get the Canary icon adapted into this new one as well?

@ppot
Copy link
Contributor

ppot commented Feb 5, 2019

@Koolstr You need to be on the master build since canary icns are not updated.

@juancampa You will need to update canary icons also.
https://github.com/zeit/hyper/tree/canary/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants