Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loopback PR redux #122

Merged
merged 4 commits into from Dec 7, 2018

Conversation

3 participants
@guybedford
Copy link
Collaborator

commented Dec 6, 2018

The previous PR that was merged was based against the bug fix it built on top of to pass... here's it back against master.

@codecov-io

This comment has been minimized.

Copy link

commented Dec 6, 2018

Codecov Report

Merging #122 into master will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   74.55%   74.94%   +0.38%     
==========================================
  Files          10       10              
  Lines         452      455       +3     
==========================================
+ Hits          337      341       +4     
+ Misses        115      114       -1
Impacted Files Coverage Δ
src/loaders/relocate-loader.js 92.96% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d3a84...8753f5c. Read the comment docs.

@guybedford

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 7, 2018

Note this is still needed to finish the merge from #117.

@guybedford guybedford force-pushed the loopback branch from 164e70f to 8753f5c Dec 7, 2018

@rauchg rauchg merged commit b042bd8 into master Dec 7, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@rauchg rauchg deleted the loopback branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.