Remove react-hot-loader

[rauchg]

It causes way more issues than it fixes.

It's a matter of removing it from babel options

    plugins: [dev && !isServer && hotLoaderItem, dev && reactJsxSourceItem].filter(Boolean)

becomes

    plugins: [dev && reactJsxSourceItem].filter(Boolean)

[timneutkens]

It’s a little more involved than just removing the babel plugin. Also requires to rewrite the provider component they have to handle errors with componentDidCatch. I’m planning to fix this after a bug fix when using _app.js

[ArmorDarks]

I wonder, which exactly issues does it cause?

[Everettss]

@ArmorDarks Some changes made in RHL 4.1.0 cause this problem: #4232

[ex3ndr]

What's alternatives? How we should auto-refresh page on changes?

[timneutkens]

Note that react-hot-loader !== hot reloading. Hot reloading still works. The only thing react-hot-loader did was keeping state, but there were too many cases in which it caused weird and unexpected behaviour. For example shouldComponentUpdate being overriden etc.

[oliviertassinari]

I confirm, it works like a charm with @material-ui/styles. I have also the feeling that the end-to-end time for hot reloading has greatly improved 🚀 .

[timneutkens]

Good to hear @oliviertassinari 😌

[msand]

This seems to have decreased hot reloading from a worst case of minutes to seconds for a handful of views, now it seems to perform as good as next.js v4, or even better. And some strange edge cases in development have disappeared. Great work.

[timneutkens]

Great 👍