Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It turned out it was bad idea to publish separate packages #5406

Closed
sheerun opened this issue Oct 8, 2018 · 1 comment
Closed

It turned out it was bad idea to publish separate packages #5406

sheerun opened this issue Oct 8, 2018 · 1 comment

Comments

@sheerun
Copy link
Contributor

sheerun commented Oct 8, 2018

Hey,

I'm writing from the future to warn you. It appears while it was nice idea to develop multiple projects in monorepo style, it ultimately was a bad idea to publish them separately (next and next-server). It turns out when you publish them separately developers can and will use incompatible versions of them. Because next-server is closely coupled to next via interfaces like getInitialProps or handling routes we need to publish them at the same time and ask everyone to add extra dependency in their package.json, plus keep them updated with matching versions :(

We wish we didn't start this and just kept publishing next-server under next/server, this way developers consuming next would always get matching versions of next and next-server as we intended.

Since time travel is now possible, you still have a chance to prevent this mess, jest don't publish stable version of next-server and prepare publishing script to put it under next/server.

@sheerun
Copy link
Contributor Author

sheerun commented Feb 11, 2019

I guess it's too late now as next-server is published

@sheerun sheerun closed this as completed Feb 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant