Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is not an issue, but please update with-portals example #5694

Closed
antandev opened this issue Nov 17, 2018 · 0 comments · Fixed by #5714
Closed

this is not an issue, but please update with-portals example #5694

antandev opened this issue Nov 17, 2018 · 0 comments · Fixed by #5714
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@antandev
Copy link

antandev commented Nov 17, 2018 •
edited

Bug report

please update with-portals example

Describe the bug

when i want to open modals i must always do double click the button before the modal opened

Expected behavior

i need to open it with one click, then i change the code to this one on componentDidMount and componentWillUnmount and it works

(update)
forgot to mention after changing the code, i also remove return null so here is my Portal.js
image
@timneutkens timneutkens added help wanted good first issue Easy to fix issues, good for newcomers labels Nov 17, 2018
darrylsepeda pushed a commit to darrylsepeda/next.js that referenced this issue Nov 20, 2018
Fix bug report with-portals example vercel#5694
c52944f
darrylsepeda pushed a commit to darrylsepeda/next.js that referenced this issue Nov 20, 2018
Fix bug report with-portals example vercel#5694
7dae360
@darrylsepeda darrylsepeda mentioned this issue Nov 20, 2018
Merged
darrylsepeda pushed a commit to darrylsepeda/next.js that referenced this issue Nov 20, 2018
Fix bug report with-portals example vercel#5694
af494a4
darrylsepeda pushed a commit to darrylsepeda/next.js that referenced this issue Nov 21, 2018
Fix bug report with-portals example vercel#5694
2fc52b7
timneutkens pushed a commit that referenced this issue Nov 21, 2018
@darrylsepeda @timneutkens
Fix bug report with-portals example #5694 (#5714)
f177be9 
I'm trying to contribute on resolving issues,
hope this help.

Fixes #5694
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug report with-portals example #5694 darrylsepeda/next.js
2 participants
@timneutkens @antandev