Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading Component.__N_SSG #10037

Merged
merged 6 commits into from Jan 14, 2020
Merged

Fix reading Component.__N_SSG #10037

merged 6 commits into from Jan 14, 2020

Conversation

tomas-c
Copy link
Contributor

@tomas-c tomas-c commented Jan 10, 2020

Closes #10036

@ijjk
Copy link
Member

ijjk commented Jan 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 13s 13.1s ⚠️ +55ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB 5.11 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..9881.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB 1.02 kB ⚠️ +1 B
link.html gzip 1.03 kB 1.03 kB -2 B
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.07 kB 3.07 kB -1 B

Diffs

Diff for main-HASH.js 
@@ -475,7 +475,7 @@
                   (data.nextExport &&
                     ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                       location.search)) ||
-                  (Component.__NEXT_SPR && location.search)
+                  (Component && Component.__NEXT_SPR && location.search)
                 ) {
                   // update query on mount for exported pages
                   router.replace(
Diff for main-HASH.module.js 
@@ -359,7 +359,7 @@
             (data.nextExport &&
               ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                 location.search)) ||
-            (Component.__NEXT_SPR && location.search)
+            (Component && Component.__NEXT_SPR && location.search)
           ) {
             // update query on mount for exported pages
             router.replace(
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      href="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6c834265eb8485e95adc.js"
+      src="/_next/static/runtime/main-858e1e5b8678aa5d26c6.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      src="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      href="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6c834265eb8485e95adc.js"
+      src="/_next/static/runtime/main-858e1e5b8678aa5d26c6.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      src="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      href="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-6c834265eb8485e95adc.js"
+      src="/_next/static/runtime/main-858e1e5b8678aa5d26c6.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-a331dd089ba7487bc805.module.js"
+      src="/_next/static/runtime/main-0bcb847ac444c3ba095b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 13.6s 13.6s ⚠️ +56ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB 5.11 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..9881.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB 77.8 kB ⚠️ +2 B
hooks.html gzip 1.05 kB 1.05 kB -1 B
index.js gzip 78 kB 78 kB ⚠️ +3 B
link.js gzip 80.4 kB 80.4 kB ⚠️ +2 B
routerDirect.js gzip 78.1 kB 78.1 kB ⚠️ +2 B
withRouter.js gzip 78.1 kB 78.1 kB ⚠️ +2 B
Overall change 393 kB 393 kB ⚠️ +10 B

Commit: 70667d9

@tomas-c @timneutkens
Use the .? optional chaining operator
151b24c 
Co-Authored-By: Tim Neutkens <tim@timneutkens.nl>
@ijjk
Copy link
Member

ijjk commented Jan 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 12.2s 363ms -11.8s
nodeModulesSize 49 MB 48.9 MB -87.7 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB N/A N/A
webpack-HASH.js gzip 746 B N/A N/A
4952ddcd88e7..54d3.js gzip 4.68 kB N/A N/A
commons.HASH.js gzip 4.06 kB N/A N/A
de003c3a9d30..9881.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB N/A N/A
Overall change 67.4 kB 0 B ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.17 kB N/A N/A
webpack-HASH..dule.js gzip 746 B N/A N/A
4952ddcd88e7..dule.js gzip 5.56 kB N/A N/A
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB N/A N/A
Overall change 62.1 kB 0 B ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB N/A N/A
Overall change 4.76 kB 0 B ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB N/A N/A
_error.js gzip 4.07 kB N/A N/A
hooks.js gzip 779 B N/A N/A
index.js gzip 222 B N/A N/A
link.js gzip 2.9 kB N/A N/A
routerDirect.js gzip 283 B N/A N/A
withRouter.js gzip 282 B N/A N/A
Overall change 9.87 kB 0 B ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B N/A N/A
_error.module.js gzip 3.06 kB N/A N/A
hooks.module.js gzip 371 B N/A N/A
index.module.js gzip 212 B N/A N/A
link.module.js gzip 2.47 kB N/A N/A
routerDirect..dule.js gzip 273 B N/A N/A
withRouter.m..dule.js gzip 272 B N/A N/A
Overall change 7.41 kB 0 B ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B N/A N/A
_buildManife..dule.js gzip 61 B N/A N/A
Overall change 122 B 0 B ✓
Rendered Page Sizes
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB N/A N/A
link.html gzip 1.03 kB N/A N/A
withRouter.html gzip 1.02 kB N/A N/A
Overall change 3.07 kB 0 B ✓

Diffs

Diff for _buildManifest.js 
deleted
Diff for _buildManifest.module.js 
deleted
Diff for _app.js 
deleted
Diff for _app.module.js 
deleted
Diff for _error.js 
deleted
Diff for _error.module.js 
deleted
Diff for hooks.js 
deleted
Diff for hooks.module.js 
deleted
Diff for index.js 
deleted
Diff for index.module.js 
deleted
Diff for link.js 
deleted
Diff for link.module.js 
deleted
Diff for routerDirect.js 
deleted
Diff for routerDirect.module.js 
deleted
Diff for withRouter.js 
deleted
Diff for withRouter.module.js 
deleted
Diff for 4952ddcd88e7..16.module.js 
deleted
Diff for 4952ddcd88e7..92a927903.js 
deleted
Diff for commons.HASH.js 
deleted
Diff for de003c3a9d30..26.module.js 
deleted
Diff for de003c3a9d30..ba6a65095.js 
deleted
Diff for framework.HASH.js 
deleted
Diff for framework.HASH.module.js 
deleted
Diff for main-HASH.js 
deleted
Diff for main-HASH.module.js 
deleted
Diff for polyfills-HASH.js 
deleted
Diff for webpack-HASH.js 
deleted
Diff for webpack-HASH.module.js 
deleted
Diff for index.html 
deleted
Diff for link.html 
deleted
Diff for withRouter.html 
deleted
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 12.7s 407ms -12.3s
nodeModulesSize 49 MB 48.9 MB -87.7 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB N/A N/A
webpack-HASH.js gzip 746 B N/A N/A
4952ddcd88e7..54d3.js gzip 4.68 kB N/A N/A
commons.HASH.js gzip 4.06 kB N/A N/A
de003c3a9d30..9881.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB N/A N/A
Overall change 67.4 kB 0 B ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.17 kB N/A N/A
webpack-HASH..dule.js gzip 746 B N/A N/A
4952ddcd88e7..dule.js gzip 5.56 kB N/A N/A
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB N/A N/A
Overall change 62.1 kB 0 B ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB N/A N/A
Overall change 4.76 kB 0 B ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB N/A N/A
_error.js gzip 4.07 kB N/A N/A
hooks.js gzip 779 B N/A N/A
index.js gzip 222 B N/A N/A
link.js gzip 2.9 kB N/A N/A
routerDirect.js gzip 283 B N/A N/A
withRouter.js gzip 282 B N/A N/A
Overall change 9.87 kB 0 B ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B N/A N/A
_error.module.js gzip 3.06 kB N/A N/A
hooks.module.js gzip 371 B N/A N/A
index.module.js gzip 212 B N/A N/A
link.module.js gzip 2.47 kB N/A N/A
routerDirect..dule.js gzip 273 B N/A N/A
withRouter.m..dule.js gzip 272 B N/A N/A
Overall change 7.41 kB 0 B ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B N/A N/A
_buildManife..dule.js gzip 61 B N/A N/A
Overall change 122 B 0 B ✓
Serverless bundles
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB N/A N/A
hooks.html gzip 1.05 kB N/A N/A
index.js gzip 78 kB N/A N/A
link.js gzip 80.4 kB N/A N/A
routerDirect.js gzip 78.1 kB N/A N/A
withRouter.js gzip 78.1 kB N/A N/A
Overall change 393 kB 0 B ✓

Commit: 151b24c

Timer
Timer requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't make sense to me – Component should always be defined. Let's make sure we understand problem first.

@Timer Timer added this to the 9.2.0 milestone Jan 10, 2020
@ijjk
Copy link
Member

ijjk commented Jan 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 11.6s 344ms -11.3s
nodeModulesSize 49 MB 48.9 MB -87.9 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB N/A N/A
webpack-HASH.js gzip 746 B N/A N/A
4952ddcd88e7..54d3.js gzip 4.68 kB N/A N/A
commons.HASH.js gzip 4.06 kB N/A N/A
de003c3a9d30..9881.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB N/A N/A
Overall change 67.5 kB 0 B ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB N/A N/A
webpack-HASH..dule.js gzip 746 B N/A N/A
4952ddcd88e7..dule.js gzip 5.56 kB N/A N/A
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB N/A N/A
Overall change 62.1 kB 0 B ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB N/A N/A
Overall change 4.76 kB 0 B ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB N/A N/A
_error.js gzip 4.07 kB N/A N/A
hooks.js gzip 779 B N/A N/A
index.js gzip 222 B N/A N/A
link.js gzip 2.9 kB N/A N/A
routerDirect.js gzip 283 B N/A N/A
withRouter.js gzip 282 B N/A N/A
Overall change 9.87 kB 0 B ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B N/A N/A
_error.module.js gzip 3.06 kB N/A N/A
hooks.module.js gzip 371 B N/A N/A
index.module.js gzip 212 B N/A N/A
link.module.js gzip 2.47 kB N/A N/A
routerDirect..dule.js gzip 273 B N/A N/A
withRouter.m..dule.js gzip 272 B N/A N/A
Overall change 7.41 kB 0 B ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B N/A N/A
_buildManife..dule.js gzip 61 B N/A N/A
Overall change 122 B 0 B ✓
Rendered Page Sizes
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB N/A N/A
link.html gzip 1.03 kB N/A N/A
withRouter.html gzip 1.02 kB N/A N/A
Overall change 3.06 kB 0 B ✓

Diffs

Diff for _buildManifest.js 
deleted
Diff for _buildManifest.module.js 
deleted
Diff for _app.js 
deleted
Diff for _app.module.js 
deleted
Diff for _error.js 
deleted
Diff for _error.module.js 
deleted
Diff for hooks.js 
deleted
Diff for hooks.module.js 
deleted
Diff for index.js 
deleted
Diff for index.module.js 
deleted
Diff for link.js 
deleted
Diff for link.module.js 
deleted
Diff for routerDirect.js 
deleted
Diff for routerDirect.module.js 
deleted
Diff for withRouter.js 
deleted
Diff for withRouter.module.js 
deleted
Diff for 4952ddcd88e7..16.module.js 
deleted
Diff for 4952ddcd88e7..92a927903.js 
deleted
Diff for commons.HASH.js 
deleted
Diff for de003c3a9d30..26.module.js 
deleted
Diff for de003c3a9d30..ba6a65095.js 
deleted
Diff for framework.HASH.js 
deleted
Diff for framework.HASH.module.js 
deleted
Diff for main-HASH.js 
deleted
Diff for main-HASH.module.js 
deleted
Diff for polyfills-HASH.js 
deleted
Diff for webpack-HASH.js 
deleted
Diff for webpack-HASH.module.js 
deleted
Diff for index.html 
deleted
Diff for link.html 
deleted
Diff for withRouter.html 
deleted
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 12.2s 355ms -11.8s
nodeModulesSize 49 MB 48.9 MB -87.9 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB N/A N/A
webpack-HASH.js gzip 746 B N/A N/A
4952ddcd88e7..54d3.js gzip 4.68 kB N/A N/A
commons.HASH.js gzip 4.06 kB N/A N/A
de003c3a9d30..9881.js gzip 13.7 kB N/A N/A
framework.HASH.js gzip 39.1 kB N/A N/A
Overall change 67.5 kB 0 B ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB N/A N/A
webpack-HASH..dule.js gzip 746 B N/A N/A
4952ddcd88e7..dule.js gzip 5.56 kB N/A N/A
de003c3a9d30..dule.js gzip 12.5 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB N/A N/A
Overall change 62.1 kB 0 B ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB N/A N/A
Overall change 4.76 kB 0 B ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB N/A N/A
_error.js gzip 4.07 kB N/A N/A
hooks.js gzip 779 B N/A N/A
index.js gzip 222 B N/A N/A
link.js gzip 2.9 kB N/A N/A
routerDirect.js gzip 283 B N/A N/A
withRouter.js gzip 282 B N/A N/A
Overall change 9.87 kB 0 B ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B N/A N/A
_error.module.js gzip 3.06 kB N/A N/A
hooks.module.js gzip 371 B N/A N/A
index.module.js gzip 212 B N/A N/A
link.module.js gzip 2.47 kB N/A N/A
routerDirect..dule.js gzip 273 B N/A N/A
withRouter.m..dule.js gzip 272 B N/A N/A
Overall change 7.41 kB 0 B ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B N/A N/A
_buildManife..dule.js gzip 61 B N/A N/A
Overall change 122 B 0 B ✓
Serverless bundles
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB N/A N/A
hooks.html gzip 1.05 kB N/A N/A
index.js gzip 78 kB N/A N/A
link.js gzip 80.4 kB N/A N/A
routerDirect.js gzip 78.1 kB N/A N/A
withRouter.js gzip 78.1 kB N/A N/A
Overall change 393 kB 0 B ✓

Commit: 17db072

@ijjk
Copy link
Member

ijjk commented Jan 14, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 13.8s 13.9s ⚠️ +49ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..9881.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB 1.02 kB ⚠️ +1 B
link.html gzip 1.03 kB 1.03 kB ⚠️ +1 B
withRouter.html gzip 1.02 kB 1.01 kB -1 B
Overall change 3.06 kB 3.06 kB ⚠️ +1 B

Diffs

Diff for main-HASH.js 
@@ -475,7 +475,7 @@
                   (data.nextExport &&
                     ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                       location.search)) ||
-                  (Component.__NEXT_SPR && location.search)
+                  (Component && Component.__NEXT_SPR && location.search)
                 ) {
                   // update query on mount for exported pages
                   router.replace(
Diff for main-HASH.module.js 
@@ -359,7 +359,7 @@
             (data.nextExport &&
               ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                 location.search)) ||
-            (Component.__NEXT_SPR && location.search)
+            (Component && Component.__NEXT_SPR && location.search)
           ) {
             // update query on mount for exported pages
             router.replace(
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      href="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-24e04d939f54ee455844.js"
+      src="/_next/static/runtime/main-8397b6ff07e28f7d8f3b.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      src="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      href="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-24e04d939f54ee455844.js"
+      src="/_next/static/runtime/main-8397b6ff07e28f7d8f3b.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      src="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      href="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-24e04d939f54ee455844.js"
+      src="/_next/static/runtime/main-8397b6ff07e28f7d8f3b.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-c26b641603395ec31912.module.js"
+      src="/_next/static/runtime/main-5f72831cf35898f87caf.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 14.2s 14.4s ⚠️ +195ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.11 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..9881.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB 77.8 kB ⚠️ +2 B
hooks.html gzip 1.05 kB 1.05 kB -1 B
index.js gzip 78 kB 78 kB ⚠️ +1 B
link.js gzip 80.4 kB 80.4 kB ⚠️ +2 B
routerDirect.js gzip 78.1 kB 78.1 kB ⚠️ +3 B
withRouter.js gzip 78.1 kB 78.1 kB ⚠️ +3 B
Overall change 393 kB 393 kB ⚠️ +10 B

Commit: a2bd2db

@Timer Timer changed the title Fix error reading Component.__NEXT_SPR in packages/next/client/index.js Fix reading Component.__NEXT_SPR Jan 14, 2020
Timer
Timer approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Timer added a commit to Timer/next.js that referenced this pull request Jan 14, 2020
@Timer
Add Test for PR vercel#10037
61c7274
@Timer Timer mentioned this pull request Jan 14, 2020
Merged
@Timer Timer changed the title Fix reading Component.__NEXT_SPR Fix reading Component.__N_SSG Jan 14, 2020
@ijjk
Copy link
Member

ijjk commented Jan 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 12.9s 13.1s ⚠️ +192ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.12 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB 1.02 kB -1 B
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.01 kB -1 B
Overall change 3.07 kB 3.06 kB -2 B

Diffs

Diff for main-HASH.js 
@@ -475,7 +475,7 @@
                   (data.nextExport &&
                     ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                       location.search)) ||
-                  (Component.__N_SSG && location.search)
+                  (Component && Component.__N_SSG && location.search)
                 ) {
                   // update query on mount for exported pages
                   router.replace(
Diff for main-HASH.module.js 
@@ -359,7 +359,7 @@
             (data.nextExport &&
               ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                 location.search)) ||
-            (Component.__N_SSG && location.search)
+            (Component && Component.__N_SSG && location.search)
           ) {
             // update query on mount for exported pages
             router.replace(
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 13.4s 13.8s ⚠️ +443ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.12 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB 77.8 kB ⚠️ +1 B
hooks.html gzip 1.06 kB 1.05 kB -2 B
index.js gzip 78 kB 78 kB ⚠️ +2 B
link.js gzip 80.4 kB 80.4 kB ⚠️ +1 B
routerDirect.js gzip 78.1 kB 78.1 kB ⚠️ +1 B
withRouter.js gzip 78.1 kB 78.1 kB ⚠️ +1 B
Overall change 393 kB 393 kB ⚠️ +4 B

Commit: 9b0c057

@ijjk
Copy link
Member

ijjk commented Jan 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 13.8s 13.7s -109ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.12 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary tomas-c/next.js issue-10036 Change
index.html gzip 1.02 kB 1.02 kB -1 B
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.01 kB -1 B
Overall change 3.07 kB 3.06 kB -2 B

Diffs

Diff for main-HASH.js 
@@ -475,7 +475,7 @@
                   (data.nextExport &&
                     ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                       location.search)) ||
-                  (Component.__N_SSG && location.search)
+                  (Component && Component.__N_SSG && location.search)
                 ) {
                   // update query on mount for exported pages
                   router.replace(
Diff for main-HASH.module.js 
@@ -359,7 +359,7 @@
             (data.nextExport &&
               ((0, _isDynamic.isDynamicRoute)(router.pathname) ||
                 location.search)) ||
-            (Component.__N_SSG && location.search)
+            (Component && Component.__N_SSG && location.search)
           ) {
             // update query on mount for exported pages
             router.replace(
Diff for index.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -168,13 +168,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -45,7 +45,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      href="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -163,13 +163,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/main-958c0bb4c1297de8088f.js"
+      src="/_next/static/runtime/main-4dc7ee942236d9bde769.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/main-d00e2d63c88a481156d8.module.js"
+      src="/_next/static/runtime/main-3f6998fe5b4d88671b6b.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
buildDuration 14.3s 14.4s ⚠️ +127ms
nodeModulesSize 49 MB 49 MB ⚠️ +24 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.js gzip 5.12 kB 5.12 kB ⚠️ +3 B
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..e54b.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.5 kB 67.5 kB ⚠️ +3 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
main-HASH.module.js gzip 4.18 kB 4.18 kB ⚠️ +3 B
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ⚠️ +3 B
Legacy Client Bundles (polyfills)
zeit/next.js canary tomas-c/next.js issue-10036 Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary tomas-c/next.js issue-10036 Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary tomas-c/next.js issue-10036 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary tomas-c/next.js issue-10036 Change
_error.js gzip 77.8 kB 77.8 kB ⚠️ +1 B
hooks.html gzip 1.06 kB 1.05 kB -2 B
index.js gzip 78 kB 78 kB ⚠️ +2 B
link.js gzip 80.4 kB 80.4 kB ⚠️ +1 B
routerDirect.js gzip 78.1 kB 78.1 kB ⚠️ +1 B
withRouter.js gzip 78.1 kB 78.1 kB ⚠️ +1 B
Overall change 393 kB 393 kB ⚠️ +4 B

Commit: 391bf7a

@Timer Timer merged commit ce2714d into vercel:canary Jan 14, 2020
Timer added a commit that referenced this pull request Jan 14, 2020
@Timer
Add Test for PR #10037 (#10093)
a2ea7a4
@snyk-bot snyk-bot mentioned this pull request Feb 11, 2020
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.0
Development

Successfully merging this pull request may close these issues.

Error page not shown when page throws at module level on client side
4 participants
@tomas-c @ijjk @Timer @timneutkens