Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change in README.md #11434

Merged
merged 3 commits into from Mar 28, 2020
Merged

Minor change in README.md #11434

merged 3 commits into from Mar 28, 2020

Conversation

liulanz
Copy link
Contributor

@liulanz liulanz commented Mar 28, 2020

I changed the link for "JOIN THE COMMUNITY" to spectrum chat channel.

It was orginally directed to the Discussions, but the label says "join us in spectrum".

I noticed that "alpha" branch does has the correct link to the spectrum chat. I think it would be better for the master branch to also have correct link.

@liulanz liulanz changed the base branch from canary to master March 28, 2020 17:40
packages/next/README.md Outdated Show resolved Hide resolved
@lfades
Copy link
Member

lfades commented Mar 28, 2020

@liulanz Please commit my suggestion and I'll approve the PR, the community is in GitHub Discussions, not in Spectrum. I've updated the aria label to mention GitHub instead.

Co-Authored-By: Luis Alvarez D. <luis@zeit.co>
@liulanz
Copy link
Contributor Author

liulanz commented Mar 28, 2020

Sorry about the link, and thank you for the help!

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💯

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh something I didn't notice, you changed the branch from canary to master, can you change it to canary again 🙏

@liulanz liulanz changed the base branch from master to canary March 28, 2020 17:57
@lfades lfades self-requested a review March 28, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants