Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade source-map package #12355

Merged
merged 8 commits into from
Apr 30, 2020
Merged

Upgrade source-map package #12355

merged 8 commits into from
Apr 30, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Apr 30, 2020 •
edited

source-map breaks in Node.js when global.fetch is defined. This was fixed in the beta.

@ijjk
Copy link
Member

ijjk commented Apr 30, 2020

Failing test suites

test/acceptance/ReactRefresh.test.js

  • logbox: can recover from a event handler error

  • logbox: can recover from a component error

Expand output

● logbox: can recover from a event handler error

JavascriptError: javascript error: Cannot read property 'innerText' of null
  (Session info: headless chrome=80.0.3987.163)

   98 |         const input = arguments[0]
   99 |         if (typeof input === 'function') {
> 100 |           const result = await browser.executeScript(input)
      |                          ^
  101 |           await new Promise(resolve => setTimeout(resolve, 30))
  102 |           return result
  103 |         } else {

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.evaluate (acceptance/helpers.js:100:26)
  at Object.<anonymous> (acceptance/ReactRefresh.test.js:308:10)

● logbox: can recover from a component error

JavascriptError: javascript error: Cannot read property 'innerText' of null
  (Session info: headless chrome=80.0.3987.163)

   98 |         const input = arguments[0]
   99 |         if (typeof input === 'function') {
> 100 |           const result = await browser.executeScript(input)
      |                          ^
  101 |           await new Promise(resolve => setTimeout(resolve, 30))
  102 |           return result
  103 |         } else {

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.evaluate (acceptance/helpers.js:100:26)
  at Object.<anonymous> (acceptance/ReactRefresh.test.js:395:10)

@Timer Timer changed the title Abort after 10s instead of 3s while testing Upgrade source-map package Apr 30, 2020
@Timer Timer marked this pull request as ready for review April 30, 2020 16:33
@Timer Timer requested review from ijjk and lfades as code owners April 30, 2020 16:33
@Timer Timer added this to the 9.3.7 milestone Apr 30, 2020
@ijjk
Copy link
Member

ijjk commented Apr 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
buildDuration 9.1s 9.1s ⚠️ +28ms
nodeModulesSize 55.8 MB 55.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.535 1.488 -0.05
/ avg req/sec 1628.77 1680.48 ⚠️ +51.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.759 0.751 -0.01
/error-in-render avg req/sec 3293.46 3327.22 ⚠️ +33.76
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
buildDuration 9.6s 9.6s -16ms
nodeModulesSize 55.8 MB 55.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
buildDuration 13.6s 13.1s -528ms
nodeModulesSize 55.8 MB 55.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.274 2.362 ⚠️ +0.09
/ avg req/sec 1099.49 1058.32 -41.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.243 1.379 ⚠️ +0.14
/error-in-render avg req/sec 2011.11 1813.03 -198.08
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
buildDuration 14.4s 14.3s -163ms
nodeModulesSize 55.8 MB 55.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js hotfix/longer-abort-for-tests Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@Timer Timer merged commit 42daf7f into vercel:canary Apr 30, 2020
@Timer Timer deleted the hotfix/longer-abort-for-tests branch May 1, 2020 16:38
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@Timer @rokinsky
Upgrade source-map package (vercel#12355)
8632e6e 
* Abort after 10s instead of 3s while testing

* skip tests to unlock CI

* re-enable tests

* fix

* Catch `performReactRefresh` errors
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @ijjk @timneutkens