Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Update firebase authentication #12687

Merged
merged 4 commits into from
May 11, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented May 10, 2020

  • Removed with-firebase-authentication as it's very outdated
  • Updated with-firebase-authentication-serverless to reduce its complexity, updated the readme, and renamed it to with-firebase-authentication. There's still a lot to do for this example as it's still very complicated and not necessarily better than our current auth examples, but that can come later.
  • Added a note in with-firebase-authentication-serverless to point to its new location.

@lfades lfades requested a review from timneutkens May 10, 2020 17:53
@lfades lfades requested a review from Timer as a code owner May 10, 2020 17:53
@Timer Timer added the examples Issue/PR related to examples label May 11, 2020
@Timer Timer added this to the 9.3.7 milestone May 11, 2020
@Timer Timer merged commit f0220e6 into vercel:canary May 11, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants