Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(next): link/router/document missing types #12692

Merged
merged 1 commit into from
May 10, 2020
Merged

chore(next): link/router/document missing types #12692

merged 1 commit into from
May 10, 2020

Conversation

maxigimenez
Copy link
Contributor

No description provided.

@ijjk
Copy link
Member

ijjk commented May 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
buildDuration 11.4s 11.6s ⚠️ +164ms
nodeModulesSize 59.6 MB 59.6 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
/ failed reqs 0 0
/ total time (seconds) 1.891 1.885 -0.01
/ avg req/sec 1321.91 1325.95 ⚠️ +4.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.077 1.096 ⚠️ +0.02
/error-in-render avg req/sec 2321.68 2281.99 -39.69
Client Bundles (main, webpack, commons)
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5ce3.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.29 kB 3.29 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_app.module.js gzip 599 B 599 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
index.html gzip 928 B 928 B
link.html gzip 938 B 938 B
withRouter.html gzip 926 B 926 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
buildDuration 12.5s 12.4s -101ms
nodeModulesSize 59.6 MB 59.6 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
main-HASH.js gzip 6.67 kB 6.67 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5ce3.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
main-HASH.module.js gzip 5.71 kB 5.71 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.29 kB 3.29 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_app.module.js gzip 599 B 599 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary maxigimenez/next.js chore/next-link-router-document-types Change
_error.js 851 kB 851 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 881 kB 881 kB
withRouter.js 881 kB 881 kB
Overall change 4.36 MB 4.36 MB

@Timer Timer merged commit 0bc0760 into vercel:canary May 10, 2020
@maxigimenez maxigimenez deleted the chore/next-link-router-document-types branch May 11, 2020 06:48
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants