Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assets size #5999

Merged
merged 5 commits into from
Jan 6, 2019
Merged

Conversation

lucleray
Copy link
Member

@lucleray lucleray commented Jan 6, 2019

It looks like :

Pages sizes after gzip:

┌ / (196 B)
├ /_app (11.5 kB)
├ /_error (4.44 kB)
├ /blog (196 B)
└ /blog/page (195 B)

(style inspired from now-cli : https://github.com/zeit/now-cli/blob/canary/src/util/output/builds.js)

I'll add dynamic chunks in a separate PR.

@timneutkens Do you want to keep _app and _error or filter them out ? I think it's a good idea to keep them, because _app can get pretty large and it would encourage code splitting in that case.

@lucleray lucleray changed the title Improve assets size (WIP) Improve assets size Jan 6, 2019
@timneutkens
Copy link
Member

timneutkens commented Jan 6, 2019

screen shot 2019-01-06 at 16 40 04

🏆 Looks perfect (taken from the test run in circle)

@timneutkens timneutkens merged commit ba95f75 into vercel:canary Jan 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants