Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup to run example with cookie authentication locally #6101

Merged
merged 8 commits into from Feb 11, 2019

Conversation

juanbzpy
Copy link
Contributor

Fixes #6096

  • Includes an index.js file in the api folder to import the login and profile microservices and serve them as an API locally.
  • Includes a custom server.js for the Next.js app to run locally and proxy the auth requests to the server API.
  • Extracts the request logic from the auth.js file and keep concerns separated.
  • Adds explanation of how everything is setup in the README.md

The goal for this PR is to make it easier to run the example locally while keeping the monorepo file structure.

@juanbzpy juanbzpy changed the title Add setup to run example locally Add setup to run example with cookie authentication locally Jan 22, 2019
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent to see the missing pieces come together! Thanks a ton for this PR.

examples/with-cookie-auth/README.md Show resolved Hide resolved
examples/with-cookie-auth/README.md Show resolved Hide resolved
examples/with-cookie-auth/README.md Show resolved Hide resolved
juanbzpy and others added 4 commits January 25, 2019 12:32
- add authorization to HOC
- add displayName to HOC
- remove unnecessary `run`s in local routing
@timneutkens timneutkens merged commit 80cb91e into vercel:canary Feb 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Instructions for with-cookie-auth example
4 participants