Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /index/index.js route not emitting the right route in production #6516

Merged
merged 5 commits into from Mar 3, 2019
Merged

Fix /index/index.js route not emitting the right route in production #6516

merged 5 commits into from Mar 3, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 2, 2019

Also added integration test in production for this

Fixes: #6285

@ijjk ijjk requested a review from timneutkens March 2, 2019 23:43
Janpot
Janpot approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks like I missed production

@timneutkens timneutkens merged commit c3b1f31 into vercel:canary Mar 3, 2019
@ijjk ijjk deleted the fix-nested-index branch March 19, 2019 00:14
@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Janpot Janpot Janpot approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index routes won't be executed in client when index.js is located in /index/index.js
3 participants
@ijjk @Janpot @timneutkens