Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove case-sensitive-paths-plugin #6587

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 10, 2019

While this is a nice feature it does filesystem operations to check if the resolved file matches the filesystem.

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/remove-case-sensitive-paths-plugin Change
Build Duration 17.2s 17.3s ⚠️ +0.82%
Client _app Size 2.67 kB 2.67 kB
Client _app gzip Size 1.12 kB 1.12 kB
Client _error Size 6.56 kB 6.56 kB
Client _error gzip Size 2.77 kB 2.77 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client main Size 20.2 kB 20.2 kB
Client main gzip Size 6.77 kB 6.77 kB
Client commons Size 190 kB 190 kB
Client commons gzip Size 61.2 kB 61.2 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.2 kB 1.2 kB
Build Dir Size 385 kB 385 kB
Average Memory Usage 147 MB 146 MB -0.46%
Max Memory Usage 208 MB 208 MB -0.04%
Average CPU Usage 95.91% 93.71% -2.29%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.8 MB 42.8 MB -0.04%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/remove-case-sensitive-paths-plugin Change
Build Duration 15.3s 15.7s ⚠️ +2.65%
Client _app Size 2.67 kB 2.67 kB
Client _app gzip Size 1.12 kB 1.12 kB
Client _error Size 6.56 kB 6.56 kB
Client _error gzip Size 2.77 kB 2.77 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client main Size 20.2 kB 20.2 kB
Client main gzip Size 6.77 kB 6.76 kB -0.01%
Client commons Size 190 kB 190 kB
Client commons gzip Size 61.2 kB 61.2 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.2 kB 1.2 kB
Build Dir Size 385 kB 385 kB
Average Memory Usage 147 MB 147 MB -0.12%
Max Memory Usage 208 MB 208 MB -0.05%
Average CPU Usage 95.48% 94.49% -1.04%
Max CPU Usage 111.11% 111.11%
node_modules Size 42.8 MB 42.8 MB -0.04%

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to be on the lookout for Windows users reporting that their applications are not reloading when files are being edited.

@timneutkens
Copy link
Member Author

👍

@timneutkens timneutkens merged commit dd60199 into vercel:canary Mar 10, 2019
@timneutkens timneutkens deleted the add/remove-case-sensitive-paths-plugin branch March 10, 2019 00:44
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants