Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading showing before pastDelay #6628

Merged
merged 3 commits into from Mar 12, 2019
Merged

Fix loading showing before pastDelay #6628

merged 3 commits into from Mar 12, 2019
+6 −5

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 12, 2019

Fixes: #6563

Timer
Timer approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 13.1s 12.7s -2.42%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ⚠️ +0.01%
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 459 kB 459 kB ✓
Average Memory Usage 128 MB 129 MB ⚠️ +0.62%
Max Memory Usage 169 MB 170 MB ⚠️ +0.65%
Average CPU Usage 92.56% 93.44% ⚠️ +0.95%
Max CPU Usage 111.11% 110% -1%
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 17.5s 15.8s -9.94%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 264 kB 264 kB ⚠️ +0%
Serverless pages/link gzip Size 62.6 kB 62.6 kB ⚠️ +0.02%
Serverless pages/index Size 259 kB 259 kB 0%
Serverless pages/index gzip Size 61.4 kB 61.4 kB 0%
Serverless pages/_error Size 260 kB 260 kB ⚠️ +0%
Serverless pages/_error gzip Size 61.4 kB 61.4 kB -0.03%
Serverless pages/routerDirect Size 259 kB 259 kB 0%
Serverless pages/routerDirect gzip Size 61.4 kB 61.5 kB ⚠️ +0.07%
Serverless pages/withRouter Size 259 kB 259 kB 0%
Serverless pages/withRouter gzip Size 61.4 kB 61.5 kB ⚠️ +0.03%
Build Dir Size 1.58 MB 1.58 MB 0%
Average Memory Usage 144 MB 144 MB -0.31%
Max Memory Usage 213 MB 210 MB -1.28%
Average CPU Usage 95.58% 98.17% ⚠️ +2.71%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 12.9s 12.3s -4.74%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 459 kB 459 kB ✓
Average Memory Usage 131 MB 129 MB -1.59%
Max Memory Usage 171 MB 171 MB -0.28%
Average CPU Usage 94.19% 93.32% -0.92%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 16.8s 17.4s ⚠️ +3.57%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 264 kB 264 kB ⚠️ +0%
Serverless pages/link gzip Size 62.5 kB 62.6 kB ⚠️ +0.16%
Serverless pages/index Size 259 kB 259 kB 0%
Serverless pages/index gzip Size 61.4 kB 61.4 kB -0.01%
Serverless pages/_error Size 260 kB 260 kB 0%
Serverless pages/_error gzip Size 61.4 kB 61.4 kB ⚠️ +0.06%
Serverless pages/routerDirect Size 259 kB 259 kB 0%
Serverless pages/routerDirect gzip Size 61.4 kB 61.4 kB -0.07%
Serverless pages/withRouter Size 259 kB 259 kB ✓
Serverless pages/withRouter gzip Size 61.5 kB 61.4 kB -0.11%
Build Dir Size 1.58 MB 1.58 MB 0%
Average Memory Usage 145 MB 143 MB -1.58%
Max Memory Usage 208 MB 213 MB ⚠️ +2.39%
Average CPU Usage 95.38% 95.19% -0.2%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 13.5s 13.1s -3.15%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 459 kB 459 kB ✓
Average Memory Usage 127 MB 129 MB ⚠️ +1.49%
Max Memory Usage 170 MB 169 MB -0.94%
Average CPU Usage 91.85% 93.59% ⚠️ +1.89%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/dynamic-delay Change
Build Duration 18.2s 17.4s -4.5%
Client _app Size 3.02 kB 3.02 kB ✓
Client _app gzip Size 1.27 kB 1.27 kB ✓
Client _error Size 7.89 kB 7.89 kB ✓
Client _error gzip Size 3.15 kB 3.15 kB ✓
Client pages/index Size 288 B 288 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 3.32 kB 3.32 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 297 B 297 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 281 B 281 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.26 kB 7.26 kB ✓
Client commons Size 188 kB 188 kB ✓
Client commons gzip Size 60.6 kB 60.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 769 B 769 B ✓
Serverless pages/link Size 264 kB 264 kB ⚠️ +0%
Serverless pages/link gzip Size 62.6 kB 62.6 kB ⚠️ +0.02%
Serverless pages/index Size 259 kB 259 kB ✓
Serverless pages/index gzip Size 61.4 kB 61.4 kB 0%
Serverless pages/_error Size 260 kB 260 kB ⚠️ +0%
Serverless pages/_error gzip Size 61.4 kB 61.4 kB -0.03%
Serverless pages/routerDirect Size 259 kB 259 kB ✓
Serverless pages/routerDirect gzip Size 61.4 kB 61.4 kB 0%
Serverless pages/withRouter Size 259 kB 259 kB ✓
Serverless pages/withRouter gzip Size 61.5 kB 61.5 kB ⚠️ +0%
Build Dir Size 1.58 MB 1.58 MB ⚠️ +0%
Average Memory Usage 142 MB 144 MB ⚠️ +1.69%
Max Memory Usage 208 MB 215 MB ⚠️ +3.07%
Average CPU Usage 95.79% 95.88% ⚠️ +0.09%
Max CPU Usage 122.22% 122.22% ✓
node_modules Size 42.4 MB 42.4 MB ⚠️ +0%

@ijjk ijjk merged commit e2944c0 into vercel:canary Mar 12, 2019
@ijjk ijjk deleted the fix/dynamic-delay branch March 12, 2019 19:12
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic import - delay and timeout feature doesn't work
2 participants
@ijjk @Timer