Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow only values that can be serialized to key #6881

Merged
merged 2 commits into from Apr 3, 2019
Merged

Allow only values that can be serialized to key #6881

merged 2 commits into from Apr 3, 2019

Conversation

timneutkens
Copy link
Member

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/allow-only-string-number-array Change
Build Duration 12.2s 12.2s ⚠️ +1ms
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.7 kB 22.7 kB ✓
Client main gzip Size 7.32 kB 7.32 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB ✓
Build Dir Size 345 kB 345 kB ✓
node_modules Size 81.9 MB 81.9 MB ⚠️ +1.04 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js fix/allow-only-string-number-array Change
Build Duration 15.5s 16.5s ⚠️ +952ms
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.7 kB 22.7 kB ✓
Client main gzip Size 7.32 kB 7.32 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 225 kB 225 kB ✓
Serverless pages/link gzip Size 59.1 kB 59.1 kB -1 B
Serverless pages/index Size 220 kB 220 kB ✓
Serverless pages/index gzip Size 57.9 kB 57.9 kB ✓
Serverless pages/_error Size 222 kB 222 kB ✓
Serverless pages/_error gzip Size 57.9 kB 57.9 kB -1 B
Serverless pages/routerDirect Size 221 kB 221 kB ✓
Serverless pages/routerDirect gzip Size 57.9 kB 57.9 kB -2 B
Serverless pages/withRouter Size 221 kB 221 kB ✓
Serverless pages/withRouter gzip Size 57.9 kB 57.9 kB -1 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB ✓
Build Dir Size 1.33 MB 1.33 MB ✓
node_modules Size 81.9 MB 81.9 MB ⚠️ +1.04 kB

@timneutkens timneutkens merged commit b384467 into vercel:canary Apr 3, 2019
@timneutkens timneutkens deleted the fix/allow-only-string-number-array branch April 3, 2019 18:45
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js fix/allow-only-string-number-array Change
Build Duration 13.5s 12.8s -670ms
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.7 kB 22.7 kB ✓
Client main gzip Size 7.32 kB 7.32 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.32 kB 1.32 kB ✓
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB ✓
Build Dir Size 345 kB 345 kB ✓
node_modules Size 81.9 MB 81.9 MB ⚠️ +1.04 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js fix/allow-only-string-number-array Change
Build Duration 17.3s 17.1s -191ms
Client _app Size 2.49 kB 2.49 kB ✓
Client _app gzip Size 1.04 kB 1.04 kB ✓
Client _error Size 8.85 kB 8.85 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.28 kB 3.28 kB ✓
Client pages/link gzip Size 1.49 kB 1.49 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 304 B 304 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 293 B 293 B ✓
Client main Size 22.7 kB 22.7 kB ✓
Client main gzip Size 7.32 kB 7.32 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.5 kB 59.5 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 225 kB 225 kB ✓
Serverless pages/link gzip Size 59.1 kB 59.1 kB -1 B
Serverless pages/index Size 220 kB 220 kB ✓
Serverless pages/index gzip Size 57.9 kB 57.9 kB -2 B
Serverless pages/_error Size 222 kB 222 kB ✓
Serverless pages/_error gzip Size 57.9 kB 57.9 kB -1 B
Serverless pages/routerDirect Size 221 kB 221 kB ✓
Serverless pages/routerDirect gzip Size 57.9 kB 57.9 kB ✓
Serverless pages/withRouter Size 221 kB 221 kB ✓
Serverless pages/withRouter gzip Size 57.9 kB 57.9 kB -2 B
Total Bundle (main, webpack, commons) Size 208 kB 208 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.1 kB 68.1 kB ✓
Build Dir Size 1.33 MB 1.33 MB ✓
node_modules Size 81.9 MB 81.9 MB ⚠️ +1.04 kB

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dav-is dav-is dav-is approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @dav-is @ijjk