Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript typing #7648

Merged
merged 9 commits into from
Jun 24, 2019
Merged

Fix TypeScript typing #7648

merged 9 commits into from
Jun 24, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Jun 24, 2019 •
edited

This correctly defines process.browser instead of process.env.browser.

It also removes process.crossOrigin because it's not found in our documentation anywhere and is mostly used for internal purposes.

This also adds a test for process.browser. 🎉

@Timer
Fix TypeScript typing
d3cc5a7 
This correctly defines `process.browser` instead of `process.env.browser`.

It also removes `process.crossOrigin` because it's not found in our documentation anywhere and is mostly used for internal purposes.
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 12.6s 12.2s -419ms
node_modules Size 41.3 MB 41.3 MB -3 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 13.7s 13.6s -92ms
node_modules Size 41.3 MB 41.3 MB -3 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB -1 B
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB -1 B
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ✓
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB -1 B
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 13.4s 13.4s ⚠️ +76ms
node_modules Size 41.3 MB 41.3 MB -3 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 14.3s 13.8s -457ms
node_modules Size 41.3 MB 41.3 MB -3 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB ⚠️ +1 B
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB ✓
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 14.9s 14.7s -147ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 15.9s 15.9s ⚠️ +37ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.1 kB 87.1 kB -1 B
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.4 kB 84.4 kB -1 B
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB -1 B
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.6 kB 84.6 kB -2 B
Build Dir Size 2.3 MB 2.3 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 12.4s 12s -357ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 12.8s 13.1s ⚠️ +230ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.2 kB 87.2 kB ✓
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.5 kB 84.5 kB -1 B
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.7 kB 84.7 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 13s 12.7s -332ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 804 kB 804 kB ✓
Click to expand serverless stats
zeit/next.js canary Timer/next.js adjust-ts-types Change
Build Duration 13.4s 13.7s ⚠️ +318ms
node_modules Size 41.3 MB 41.3 MB ⚠️ +276 B
Total Bundle (main, webpack, commons) Size 213 kB 213 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70 kB 70 kB ⚠️ +1 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.78 kB 8.78 kB ✓
Client _error gzip Size 3.31 kB 3.31 kB -1 B
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.79 kB 4.79 kB ✓
Client pages/link gzip Size 2.05 kB 2.05 kB -1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 27.6 kB 27.6 kB ✓
Client main gzip Size 9.13 kB 9.13 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 339 kB 339 kB ✓
Serverless pages/link gzip Size 87.2 kB 87.2 kB -1 B
Serverless pages/index Size 330 kB 330 kB ✓
Serverless pages/index gzip Size 84.7 kB 84.7 kB ✓
Serverless pages/_error Size 330 kB 330 kB ✓
Serverless pages/_error gzip Size 84.5 kB 84.5 kB -2 B
Serverless pages/routerDirect Size 331 kB 331 kB ✓
Serverless pages/routerDirect gzip Size 84.7 kB 84.7 kB -1 B
Serverless pages/withRouter Size 331 kB 331 kB ✓
Serverless pages/withRouter gzip Size 84.7 kB 84.7 kB -1 B
Build Dir Size 2.3 MB 2.3 MB ✓

timneutkens
timneutkens reviewed Jun 24, 2019
View reviewed changes
packages/next/types/global.d.ts
// Extend the NodeJS namespace with Next.js-defined properties
declare namespace NodeJS {
interface Process {
readonly browser: boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document typeof window !== 'undefined' in the docs.

@Timer Timer merged commit 353e505 into vercel:canary Jun 24, 2019
@Timer Timer deleted the adjust-ts-types branch June 24, 2019 18:26
@kachkaev kachkaev mentioned this pull request Aug 15, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk ijjk approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @timneutkens @ijjk