Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid href in with-tailwindcss example #8488

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Fix invalid href in with-tailwindcss example #8488

merged 1 commit into from
Aug 23, 2019

Conversation

HaNdTriX
Copy link
Contributor

next/link should only be used for internal links.

Error

Uncaught (in promise) Error: Invalid href passed to router: https://github.com/zeit/next.js https://err.sh/zeit/next.js/invalid-href-passed

@ijjk
Copy link
Member

ijjk commented Aug 23, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
buildDuration 22.5s 22.4s -110ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
link 3.75 kB 3.75 kB ✓
link gzip 964 B 965 B ⚠️ +1 B
index 3.69 kB 3.69 kB ✓
index gzip 957 B 956 B -1 B
withRouter 3.75 kB 3.75 kB ✓
withRouter gzip 951 B 951 B ✓
Overall change ✓
Serverless Mode
General
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
buildDuration 24.1s 24.2s ⚠️ +127ms
nodeModulesSize 41.2 MB 41.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary HaNdTriX/next.js examples/tailwindcss Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.2 kB 66.4 kB ⚠️ +186 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 978 B 978 B ✓
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB -20 B
link.js 255 kB 255 kB ✓
link.js gzip 68.9 kB 68.8 kB -125 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.6 kB 66.7 kB ⚠️ +23 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.7 kB 66.7 kB ⚠️ +13 B
Overall change ✓

@Timer Timer added ready to land examples Issue/PR related to examples labels Aug 23, 2019
@Timer Timer added this to the 9.0.5 milestone Aug 23, 2019
@Timer Timer merged commit 7eda3bc into vercel:canary Aug 23, 2019
@HaNdTriX HaNdTriX deleted the examples/tailwindcss branch August 23, 2019 13:40
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@HaNdTriX @ijjk @Timer