Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve prettier ignore #8753

Merged
merged 1 commit into from Sep 16, 2019
Merged

Improve prettier ignore #8753

merged 1 commit into from Sep 16, 2019
+3 −0

Conversation

huv1k
Copy link
Contributor

@huv1k huv1k commented Sep 16, 2019

This ignores compiled files running for prettier

@huv1k huv1k requested a review from Timer as a code owner September 16, 2019 12:15
@timneutkens timneutkens merged commit 3e81ace into vercel:canary Sep 16, 2019
@huv1k huv1k deleted the prettier-ignore branch September 16, 2019 12:18
@ijjk
Copy link
Member

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary huv1k/next.js prettier-ignore Change
buildDuration 14.6s 14.5s -139ms
nodeModulesSize 42 MB 42 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary huv1k/next.js prettier-ignore Change
main-HASH.js 18.2 kB 18.2 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB ✓
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary huv1k/next.js prettier-ignore Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.4 kB 6.4 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary huv1k/next.js prettier-ignore Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.11 kB 8.11 kB ✓
link.js gzip 3.48 kB 3.48 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary huv1k/next.js prettier-ignore Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.5 kB 8.5 kB ✓
link.module.js gzip 3.66 kB 3.66 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary huv1k/next.js prettier-ignore Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary huv1k/next.js prettier-ignore Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 946 B 946 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 953 B 953 B ✓
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 10.9 kB 10.9 kB ✓
Serverless Mode
General
zeit/next.js canary huv1k/next.js prettier-ignore Change
buildDuration 14.6s 14.2s -468ms
nodeModulesSize 42 MB 42 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary huv1k/next.js prettier-ignore Change
main-HASH.js 18.2 kB 18.2 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB ✓
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary huv1k/next.js prettier-ignore Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.4 kB 6.4 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary huv1k/next.js prettier-ignore Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.11 kB 8.11 kB ✓
link.js gzip 3.48 kB 3.48 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary huv1k/next.js prettier-ignore Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.5 kB 8.5 kB ✓
link.module.js gzip 3.66 kB 3.66 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary huv1k/next.js prettier-ignore Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary huv1k/next.js prettier-ignore Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.2 kB 66.2 kB ✓
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 978 B 978 B ✓
index.js 248 kB 248 kB ✓
index.js gzip 66.5 kB 66.5 kB ✓
link.js 255 kB 255 kB ✓
link.js gzip 68.5 kB 68.5 kB ✓
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ✓
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB ✓
Overall change 1.25 MB 1.25 MB ✓

Commit: be0a64b

@huv1k huv1k added this to the 9.0.6 milestone Sep 16, 2019
This was referenced Jun 1, 2020
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huv1k @ijjk @timneutkens