Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor with-portals example #9097

Merged
merged 4 commits into from
Oct 18, 2019
Merged

Refactor with-portals example #9097

merged 4 commits into from
Oct 18, 2019

Conversation

HaNdTriX
Copy link
Contributor

Changelog

  • Use functional components instead of class components
  • Use default exports like in all other examples
  • Rename Portal component to ClientOnlyPortal.

@HaNdTriX
Refactor with-modal example
2ebe913 
## Changelog

- Use functional components instead of class components
- Use default exports like in all other examples
- Rename `Portal` component to `ClientOnlyPortal`.
@Timer Timer added ready to land examples Issue/PR related to examples labels Oct 18, 2019
@Timer Timer added this to the 9.1.2 milestone Oct 18, 2019
Timer
Timer approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Timer Timer merged commit 2874a3e into vercel:canary Oct 18, 2019
@HaNdTriX HaNdTriX deleted the examples/with-portals branch October 18, 2019 12:22
This was referenced Nov 12, 2019
Merged
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@HaNdTriX @Timer