Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example/with-dynamic-import #9667

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Update example/with-dynamic-import #9667

merged 4 commits into from
Dec 9, 2019

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Dec 8, 2019

Changelog

  • Migrate to function components
  • Remove deprecated modules syntax
  • Remove description
  • Remove Counter

@HaNdTriX HaNdTriX changed the title Update examples with-dynamic-import Update example/with-dynamic-import Dec 8, 2019
lfades
lfades approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaNdTriX Nice, thank you 💯

@lfades lfades merged commit 8a04353 into vercel:canary Dec 9, 2019
@HaNdTriX HaNdTriX deleted the examples/with-dynamic-import branch December 9, 2019 07:49
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaNdTriX @lfades