[now dev] Fix the path provided to lambda invocations
#2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches how the Now proxy invokes the lambdas, where the route `dest` query params are mixed-in to the provided `req.url`, with the dest query params taking precedence over any conflicting user-provided query params.
Codecov Report
@@ Coverage Diff @@
## canary #2036 +/- ##
=========================================
- Coverage 6.18% 6.15% -0.04%
=========================================
Files 86 86
Lines 4072 4079 +7
=========================================
- Hits 252 251 -1
- Misses 3820 3828 +8
Continue to review full report at Codecov.
|
TooTallNate
added a commit
that referenced
this pull request
Apr 1, 2019
This matches how the Now proxy invokes the lambdas, where the route `dest` query params are mixed-in to the provided `req.url`, with the dest query params taking precedence over any conflicting user-provided query params.
leo
pushed a commit
that referenced
this pull request
Apr 1, 2019
This matches how the Now proxy invokes the lambdas, where the route `dest` query params are mixed-in to the provided `req.url`, with the dest query params taking precedence over any conflicting user-provided query params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches how the Now proxy invokes the lambdas, where the route
destquery params are mixed-in to the providedreq.url, with the dest query params taking precedence over any conflicting user-provided query params.