Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit the process immediately upon Ctrl+C #540

Merged
merged 1 commit into from
May 15, 2017

Conversation

TooTallNate
Copy link
Member

During the deployment selection prompt, don't print out a stack
trace of the "Aborted" error to the user, just exit the process
directly.

During the deployment selection prompt, don't print out a stack
trace of the "Aborted" error to the user, just exit the process
directly.
@rauchg rauchg merged commit 4f64762 into master May 15, 2017
@rauchg rauchg deleted the fix/deployment-type-ctrl-c-abort branch May 15, 2017 20:17
@rauchg
Copy link
Member

rauchg commented May 15, 2017

Question: do we still need the exit() wrapper?

@TooTallNate
Copy link
Member Author

Before:

❯ now
> Deploying ~/GitHub/zeit/ace-resolve under zeit
> Two manifests found. Press [n] to deploy or re-run with --flag
> [1] package.json	   --npm
> [2] Dockerfile	--docker
Error: Aborted
    at ReadStream.ondata (/snapshot/home/travis/build/zeit/now-cli/lib/utils/prompt-options.js:20:16)
    at emitOne (events.js:96:13)
    at ReadStream.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at ReadStream.Readable.push (_stream_readable.js:134:10)
    at TTY.onread (net.js:551:20)
> Error! Unknown error: Error: Aborted
Error: Aborted
    at bail (/snapshot/home/travis/build/zeit/now-cli/node_modules/async-retry/lib/index.js:14:39)
    at retry (/snapshot/home/travis/build/zeit/now-cli/bin/now-deploy.js:403:22)
    at process._tickCallback (internal/process/next_tick.js:103:7)

Now:

❯ now
> Deploying ~/GitHub/zeit/ace-resolve under zeit
> Two manifests found. Press [n] to deploy or re-run with --flag
> [1] package.json	   --npm
> [2] Dockerfile	--docker

@TooTallNate
Copy link
Member Author

Question: do we still need the exit() wrapper?

Good question. I think not for newest versions of Node.js, but then the question is how far back do we support?

TooTallNate pushed a commit that referenced this pull request Aug 23, 2019
…#540)

* Add support for `go.mod` in different `entrypoint` directory

* Add tests cover Go Modules

* Workaround solution to make `now dev` support `go.mod` in different folder than `entrypoint`

* Ensure to backup `go.mod` and `go.sum` only in isDev

* Update packages/now-go/index.ts

* Update packages/now-go/index.ts

* Update watcher to work for different local packages under the same `go.mod`

* Improve code readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants