[now-python] Fix headers with multiple values #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
approved these changes
Sep 20, 2019
Codecov Report
@@ Coverage Diff @@
## canary #3053 +/- ##
==========================================
+ Coverage 13.46% 13.47% +0.01%
==========================================
Files 267 267
Lines 10296 10300 +4
Branches 1211 1212 +1
==========================================
+ Hits 1386 1388 +2
- Misses 8848 8850 +2
Partials 62 62
Continue to review full report at Codecov.
|
styfle
added a commit
that referenced
this pull request
Sep 30, 2019
* [now-python] Add format_headers() * Add tests * Fix filenames * Fix test probes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3051
I updated all three possible interfaces:
I swapped requests for the built-in
http.clientbecause I found thatrequestsdoes something a little strange: it combines multiple keys into a dictionary with a CSV value which I believe is incorrect so I use myformat_headers()instead which will use an array/list for the value.