[now-next] Upload build-time generated static artifacts #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #3096 +/- ##
=========================================
+ Coverage 11.33% 13.3% +1.96%
=========================================
Files 268 268
Lines 10064 10330 +266
Branches 1314 1217 -97
=========================================
+ Hits 1141 1374 +233
- Misses 8830 8893 +63
+ Partials 93 63 -30
Continue to review full report at Codecov.
|
Timer
added
@now/next
triaged: feature request
Timer
changed the title
Timer
removed
the
triaged: feature request
Timer
approved these changes
Sep 30, 2019
styfle
pushed a commit
that referenced
this pull request
Oct 3, 2019
For context, when you have a script that generates a new static file at build time (`sitemap.xml` for example), it has to be inside `.next/static`, and then you'll need a Now route for it, with this change you could generate the file inside `public`/`static` and the builder will now take care of it. The util `includeOnlyEntryDirectory` is no longer being used after this change, should I remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, when you have a script that generates a new static file at build time (
sitemap.xmlfor example), it has to be inside.next/static, and then you'll need a Now route for it, with this change you could generate the file insidepublic/staticand the builder will now take care of it.The util
includeOnlyEntryDirectoryis no longer being used after this change, should I remove it?