[now-node] Fix helpers when POST json has empty body #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the unit tests need to be updated 🤔 |
lucleray
reviewed
Oct 21, 2019
| @@ -78,13 +82,15 @@ function status(res: NowResponse, statusCode: number): NowResponse { | |||
| } | |||
|
|
|||
| function setCharset(type: string, charset: string) { | |||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
There was a problem hiding this comment.
You can add a single line for these at the beginning of the file OR if the rule doesn't make sense for us, you can turn it off for the whole repo in eslintrc.json
TooTallNate
pushed a commit
that referenced
this pull request
Oct 21, 2019
The `@now/node` helpers json parsing is too strict and doesn't match the behavior of Express when an incoming request has `{ method: 'POST', Content-Type: 'application/json', body: '' }`.
Instead of returning 400, this PR will continue with `body = {}` to match Express.
Fixes https://spectrum.chat/zeit/now/klarna-with-zeit-now~60852003-4db6-4ec4-a611-83b2349ece08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@now/nodehelpers json parsing is too strict and doesn't match the behavior of Express when an incoming request has{ method: 'POST', Content-Type: 'application/json', body: '' }.Instead of returning 400, this PR will continue with
body = {}to match Express.Fixes https://spectrum.chat/zeit/now/klarna-with-zeit-now~60852003-4db6-4ec4-a611-83b2349ece08