[now-cli] Use npx when available to run dev command #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucleray
requested review from
AndyBitz,
leo,
styfle and
TooTallNate
as code owners
styfle
reviewed
Feb 5, 2020
| @@ -1651,7 +1652,6 @@ export default class DevServer { | |||
| const env: EnvConfig = { | |||
| ...process.env, | |||
| ...this.buildEnv, | |||
| PATH: `${yarnBinPath}${delimiter}${process.env.PATH}`, | |||
There was a problem hiding this comment.
@TooTallNate Don't we bundle yarn with now-cli for this exact purpose?
There was a problem hiding this comment.
Good question, I'm also curious about this.
styfle
reviewed
Feb 5, 2020
| @@ -1664,11 +1664,22 @@ export default class DevServer { | |||
| })}` | |||
| ); | |||
|
|
|||
| const p = spawnCommand(this.devCommand, { | |||
There was a problem hiding this comment.
This spawnCommand already has a condition for Windows https://github.com/zeit/now/blob/b0e4f2590d14e79329dbd70a6aeb2b63a244d3c6/packages/now-build-utils/src/fs/run-user-scripts.ts#L84
leo
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
npxis found, use it to run dev command. Ifnpxis not available, useyarn binto find bin path and run command from bin path.