Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New update-checker breaks compatibility with Read Only filesystems #351

Closed
tomgco opened this issue Apr 11, 2018 · 2 comments · Fixed by #352
Closed

New update-checker breaks compatibility with Read Only filesystems #351

tomgco opened this issue Apr 11, 2018 · 2 comments · Fixed by #352

Comments

@tomgco
Copy link

tomgco commented Apr 11, 2018

The Pull Request: #347 has introduced a new update checking module. This module tries to create a temporary folder and file under /tmp - /tmp/update-check/serve-latest.json.

However in our deployments, as our file-systems are Read Only the new update breaks. The previous point release 6.5.3 was compatible and working with our setup, whereas 6.5.4 has broken this compatibility.

Operating System: Alpine Linux
Node: 8.11.1

A stack trace can be found below:

(node:6) UnhandledPromiseRejectionWarning: Error: EROFS: read-only file system, mkdir '/tmp/update-check'
(node:6) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:6) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:6) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/tmp/update-check/serve-latest.json'
(node:6) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
GlenTiki added a commit to GlenTiki/serve that referenced this issue Apr 11, 2018
@leo leo closed this as completed in #352 Apr 11, 2018
leo pushed a commit that referenced this issue Apr 11, 2018
@GlenTiki
Copy link
Contributor

Notice for anyone else who ends up here: you're probably trying to run serve in a production env. If you set the NODE_ENV env variable to be production, this issue should go away ✨

@leo
Copy link
Contributor

leo commented Apr 11, 2018

Fixed in the latest release! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants