Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pallets] Execute migrations for parachain-staking #462

Closed
3 tasks done
sea212 opened this issue Feb 21, 2022 · 3 comments · Fixed by #488
Closed
3 tasks done

[Pallets] Execute migrations for parachain-staking #462

sea212 opened this issue Feb 21, 2022 · 3 comments · Fixed by #488
Assignees
Labels
p:high High priority, prioritize the resolution of this issue t:maintenance The issue describes necessary maintenance

Comments

@sea212
Copy link
Member

sea212 commented Feb 21, 2022

Execute all parachain-staking migrations (between a1956695d7eeb83f095908b56cce3b3e69e039c4 and 45257659f04b28dd4927b5dc611fac6f9e8905fd

Relevant migrations:

@sea212 sea212 added p:high High priority, prioritize the resolution of this issue t:maintenance The issue describes necessary maintenance labels Feb 21, 2022
@sea212 sea212 added this to the v0.3.0 milestone Feb 21, 2022
@4meta5
Copy link

4meta5 commented Mar 10, 2022

@sea212 All 3 migrations are not related so they can be executed in the same block if necessary. Uncomment the required migrations and functions if they are used in the migration.

I don't see where the migrations are used in #458 , moonbeam uses pallet-migrations instead of on_runtime_upgrade in the pallet so these migrations are not executed by default if you do not have pallet-migrations in your runtimes.

@sea212
Copy link
Member Author

sea212 commented Mar 10, 2022

@4meta5 Thanks a lot for the input. So I assume the following way is a valid and error-free approach: We create a fork, uncomment the migration that's commented out, and apply all migrations specified in this issue by adding the respective structs that implement OnRuntimeUpgrade to the Executive type.

@4meta5
Copy link

4meta5 commented Mar 10, 2022

That should work. If you have any trouble with it, feel free to ping me on Riot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:high High priority, prioritize the resolution of this issue t:maintenance The issue describes necessary maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants