Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradation of cities-with-1000 dependency #18

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Conversation

nabilashraf
Copy link
Contributor

  • cities-with-1000 bumped to v1.0.4
  • cities.pbf built with latest file from geonames.org

@zeke zeke merged commit 6e1c74a into zeke:master Mar 18, 2020
@zeke
Copy link
Owner

zeke commented Mar 18, 2020

Thanks!

~/git/zeke/all-the-cities master
$ np minor

Publish a new version of all-the-cities (current: 3.0.0)

Commits:
- Merge pull request #18 from nabilashraf/master  6e1c74a
- Merge branch 'master' of https://github.com/nabilashraf/all-the-cities  50e33d2
- :sparkles: Upgarded cities.pbf and dependencies  821ff7d
- :sprakles: Upgarded cities.pbf and dependencies  1ffa63c
- Merge pull request #14 from oprogramador/patch-1  20bfb0c
- refine example formatting  c3b5ee9

  ✔ Prerequisite check
  ✔ Git
  ↓ Cleanup [skipped]
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Enabling two-factor authentication
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

 all-the-cities 3.1.0 published 🎉

@zeke
Copy link
Owner

zeke commented Mar 18, 2020

Out of curiosity, what are you using this module for? Anything fun?

@nabilashraf
Copy link
Contributor Author

I used this for a client of mine who wanted to have population and Geospatial data available when someone queries a radius search for all the regions close to them for weather conditions. But it can be used in much more, I believe if the module can be linked directly with geonames api / etc to always get latest data and we don't have to build multiple times. And config to adjust fields that are received. Probably have to rewrite the module in that sense but that could be something.

@zeke
Copy link
Owner

zeke commented Mar 19, 2020

That sounds interesting. This could be a good use case for the "serverless" lambda functions using something like https://functions.netlify.com

@nabilashraf
Copy link
Contributor Author

Totally. Let's share some ideas to move this module to a serverless model. What do you think?

@zeke
Copy link
Owner

zeke commented Mar 30, 2020

I think this module can remain what it is without changes. It works well in Node.js environments.

The serverless project could be a separate repo that depends on this module for data, but is designed for browser-based apps that need to make one-off requests for city data.

@nabilashraf
Copy link
Contributor Author

Makes perfect sense. Do you want to create a repo or should I?

@zeke
Copy link
Owner

zeke commented Mar 31, 2020

Go for it. Feel free to invite me to follow along, review PRs, etc

@zeke
Copy link
Owner

zeke commented Aug 8, 2020

Hey @nabilashraf 👋🏼

I ended up publishing my nearby-cities module as a Netlify function. Thought you might like to know.

See https://github.com/zeke/nearby-cities#online-usage

Example query: https://nearby-cities.netlify.app/.netlify/functions/search?latitude=37.871593&longitude=-122.272743

@nabilashraf
Copy link
Contributor Author

Hey @nabilashraf 👋🏼

I ended up publishing my nearby-cities module as a Netlify function. Thought you might like to know.

See https://github.com/zeke/nearby-cities#online-usage

Example query: https://nearby-cities.netlify.app/.netlify/functions/search?latitude=37.871593&longitude=-122.272743

This is so cool @zeke. Sorry I couldn't start earlier, can we have an option to choose the population factor, that will make this function a wholesome experience. I believe the population factor was what had been asked a lot.

But anyways cheers man for this wonderful package! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants