Added automatic HTTP status code checking.

lib/monster_mash/base.rb

@@ -1,4 +1,8 @@
 module MonsterMash
+  class HTTPError < StandardError
+    attr_accessor :response
+  end
+
   class Base
     include ClassLevelInheritableAttributes
     inheritable_attributes :defaults
@@ -60,8 +64,13 @@ def #{name}(*args, &block)
       end
     end
 
-    def inherited(subclass)
-
+    def self.check_response_and_raise!(response)
+      code = response.code.to_i
+      if code < 200 or code >= 400
+        error = MonsterMash::HTTPError.new("Got bad HTTP response! code: #{code}")
+        error.response = response
+        raise error
+      end
     end
 
     private

spec/monster_mash/base_spec.rb

@@ -67,6 +67,43 @@ class C < A
     end
   end
 
+  describe "#check_response_and_raise!" do
+    before(:each) do
+      @response = mock('response')
+    end
+
+    it "should raise if a response has a code in the wrong range" do
+      bad_codes = [0, 404, 500, 403, 410, 400]
+      bad_codes.each do |code|
+        @response.stub!(:code).and_return(code)
+        lambda {
+          MonsterMash::Base.check_response_and_raise!(@response)
+        }.should raise_error(MonsterMash::HTTPError)
+      end
+    end
+
+    it "should not raise if a response has good codes" do
+      good_codes = [200, 204, 301, 302]
+      good_codes.each do |code|
+        @response.stub!(:code).and_return(code)
+        lambda {
+          MonsterMash::Base.check_response_and_raise!(@response)
+        }.should_not raise_error(MonsterMash::HTTPError)
+      end
+    end
+
+    it "should propagate the response object with the error" do
+      @response.stub!(:code).and_return(400)
+      error = nil
+      begin
+        MonsterMash::Base.check_response_and_raise!(@response)
+      rescue => e
+        error = e
+      end
+      error.response.should == @response
+    end
+  end
+
   describe "#delete" do
     it "should proxy to build_method" do
       MockApi.should_receive(:build_method).