Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline #8

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Add newline #8

merged 3 commits into from
Aug 28, 2018

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Aug 23, 2018

Add a missing newline to the end of the file. Also update deps.

@zeke
Copy link
Owner

zeke commented Aug 24, 2018

Thanks @bcomnes! Looks like CI is failing though.

const spawn = require('child_process').spawn;
^^^^^
SyntaxError: Use of const in strict mode.

Feel free to rectify this however you feel, either by removing use strict, bumping the node version, changing const to `var...

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 24, 2018

Aw shucks. Ok, trying with LTS and latest.

@zeke zeke merged commit 1a479b3 into zeke:master Aug 28, 2018
@zeke
Copy link
Owner

zeke commented Aug 28, 2018

$ np patch
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using npm
 ✔ Running tests
 ✔ Bumping version using npm
 ✖ Publishing package
   → npm ERR!     /Users/z/.npm/_logs/2018-08-28T04_28_47_161Z-debug.log
   Pushing tags

✖ Command failed: npm publish
npm WARN notice Maintenance in progress: http://stspg.io/bace37b38
npm WARN notice Maintenance in progress: http://stspg.io/bace37b38
npm WARN notice Maintenance in progress: http://stspg.io/bace37b38
npm ERR! publish Failed PUT 503
npm ERR! code E503
npm ERR! Maintenance in progress: http://stspg.io/bace37b38 : npe

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/z/.npm/_logs/2018-08-28T04_28_47_161Z-debug.log

I'll give this another try tomorrow...

@zeke
Copy link
Owner

zeke commented Aug 28, 2018

$ np patch
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using npm
 ✔ Running tests
 ✔ Bumping version using npm
 ✔ Publishing package
 ✔ Pushing tags

 npe 1.1.3 published 🎉

Thanks Bret 🙌

@bcomnes bcomnes deleted the add-newline branch August 28, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants