feat: add config option to only lint commits #33
Conversation
| const commits = await context.github.pullRequests.getCommits(context.repo({ | ||
| number: context.payload.pull_request.number | ||
| })) | ||
|
|
||
| return commits.data | ||
| .map(element => element.commit) | ||
| .some(commit => isSemanticMessage(commit.message)) | ||
| .map(element => element.commit)[allCommits ? 'every' : 'some'](commit => isSemanticMessage(commit.message)) |
There was a problem hiding this comment.
This is operation to invoke either every or some on the array can be controversial. I'm happy to change it to a more verbose version if you like
lib/handle-pull-request-change.js
Outdated
| const state = isSemantic ? 'success' : 'pending' | ||
|
|
||
| function getDescription () { | ||
| if (hasSemanticTitle) return 'ready to be squashed' | ||
| if (hasSemanticCommits) return 'ready to be merged or rebased' | ||
| if (titleOnly) return 'add a semantic PR title' | ||
| if (commitsOnly) return 'add a semantic commit' |
There was a problem hiding this comment.
add a semantic commit
Shouldn't this message be something more like "make sure every commit is semantic"?
This gets at the root of the trouble with this new commitsOnly option: People will have to amend their commit history in order to comply with it. Many people don't know how to do that. I guess the challenge here is to convey that in a very short status message...
There was a problem hiding this comment.
Really good point. I've updated the wording as suggested.
Useful when using Rebase + Merge as merge strategy. Closes zeke#31
stefanbuck
force-pushed
the
feat-commitsOnly
branch
from
c223456
to
ac43180
Compare
|
I am new to using Github Apps, since I have configured the bot via the normal Github App workflow when can I expect changes in this repo to be live in the app? Does an official release have to be made first? I ask because I am not sure if I have configured the bot correctly or not via this PR influxdata/flux#444. |
This app is deployed to Heroku and integrated with GitHub to autodeploy changes to the
It makes sense to me that your test PR is passing: there's only one commit and it has a semantic prefix: influxdata/flux@20ab001 |
Useful when using Rebase + Merge as merge strategy.
Closes #31
View rendered README.md