Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Guild Member Fetching on Startup fails (sometimes) #252

Closed
zekroTJA opened this issue Jul 10, 2021 · 0 comments
Closed

[BUG] Guild Member Fetching on Startup fails (sometimes) #252

zekroTJA opened this issue Jul 10, 2021 · 0 comments
Assignees
Labels
bug Something isn't working core critical Something breaking

Comments

@zekroTJA
Copy link
Owner

Sometimes on startup, only a fraction of the present guilds are collected for member fetching on ready event.

That might be because the ready listener in the Ready handler occasionally fires before the ready handler of dgrs which caches guilds received on ready event.

The error might be introduced here:

guilds, err := l.st.Guilds()
if err != nil {
logrus.WithError(err).Error("READY :: failed getting guilds")

It might be fixed by using the guilds from the ready event there as well independent of the currently cached guilds, because the list of guilds are the same for both event handlers.

@zekroTJA zekroTJA added bug Something isn't working core labels Jul 10, 2021
@zekroTJA zekroTJA self-assigned this Jul 10, 2021
@zekroTJA zekroTJA added the critical Something breaking label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core critical Something breaking
Projects
None yet
Development

No branches or pull requests

1 participant