Doc Actor: En_Brob (Jabu Jabu Wobble Flesh Block) #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
reviewed
Nov 14, 2023
fig02
approved these changes
Nov 16, 2023
Dragorn421
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Good job :)
EnBrob_Stunned is a bit weird because it's not the stunned state itself, it's only the "goes to stunned" animation and the actual stunned state (including when you can walk on the blob) is part of EnBrob_Idle, but oh well
I only have one comment on the limb symbol names
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Dragorn421
approved these changes
Nov 19, 2023
krm01
pushed a commit
to krm01/oot-public
that referenced
this pull request
Nov 19, 2023
* brob function naming * modified brob header file * renamed skel, collision, and anims * named limbs and dls * renamed shock function * ran formatter * doc modifications * Update assets/xml/objects/object_brob.xml Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com> --------- Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First actor documentation attempt, feel free to let me know anything I've done wrong, should be changed, or that I missed. Suggestion welcome as well.
Don't be afraid to tear into it, no better way to learn than through experience.
I was very unsure about the DL/Limb names, there were limbs inside of limbs that did nothing, so I checked another actor and they seemed to follow this pattern.