Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes/matches #3

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Various fixes/matches #3

merged 1 commit into from
Mar 18, 2020

Conversation

Roman971
Copy link
Collaborator

  • Matched all remaining functions in __osMalloc.c, 2 functions in code_8007BF90.c, 1 in code_800A9F30.c, 2 in fault.c, 1 in fault_drawer.c, 1 in gfxprint.c, 2 in z_camera.c (18 total)
  • Improved most other remaining non matchings to ensure they are actually equivalent and to get them closer to matching
  • Added a alloc.h header file in the process of working on fault.c non matchings
  • Decompiled padmgr.c data/bss in order to improve padmgr non matchings
  • Removed unused z_en_wallmas.c data files
  • Moved functions confirmed to be in z_cheap_proc.c to their own file with that name

- Matched all remaining functions in `__osMalloc.c`, 2 functions in `code_8007BF90.c`, 1 in `code_800A9F30.c`, 2 in `fault.c`, 1 in `fault_drawer.c`, 1 in `gfxprint.c`, 2 in `z_camera.c`
-  Improved most other remaining non matchings to ensure they are actually equivalent and to get them closer to matching
- Added a `alloc.h` header file in the process of working on `fault.c` non matchings
- Decompiled `padmgr.c` data/bss in order to improve padmgr non matchings
- Removed unused `z_en_wallmas.c` data files
- Moved functions confirmed to be in `z_cheap_proc.c` to their own file with that name
@fig02 fig02 merged commit 5fc1f7a into zeldaret:master Mar 18, 2020
@Roman971 Roman971 deleted the fixes-matches branch March 18, 2020 12:17
i82orbom pushed a commit to i82orbom/oot that referenced this pull request Aug 18, 2020
fig02 pushed a commit that referenced this pull request Aug 18, 2020
* Decompiles z_en_wonder_talk.c

	* EnWonderTalk_Init
	* EnWonderTalk_Update
	* func_80B395F0
	* func_80B391CC
	* func_80B3943C

Removes unused asm's

* Addresses PR comments

* Uses VT macros in z_en_wonder_talk

* Adds translations to stdout messages in comments

* Addresses additional PR comments

* Addresses PR comments #3

Co-authored-by: i82orbom <i82orbom@github>
Co-authored-by: i82orbom <i82orbom i82orbom@github>
i82orbom pushed a commit to i82orbom/oot that referenced this pull request Aug 23, 2020
fig02 pushed a commit that referenced this pull request Aug 24, 2020
* Starts decompiling z_bg_dodoago.c

	* Removes data

* * BgDodoago_SetupAction

* * BgDodoago_Destroy

* * func_80872288

* * BgDodoago_Draw

* * func_80871A08

* * BgDodoago_Init

* WIP

* * func_80871CF4

* * func_80871CF4

* WIP

* * BgDodoago_Update

* Finishes z_bg_dodoago

* Addresses PR comments

* Addresses PR comments #2

* Removes Setup forward declared function

* Addresses PR comments #3

Co-authored-by: i82orbom <i82orbom i82orbom@github>
Dragorn421 referenced this pull request in Dragorn421/oot Aug 8, 2021
AngheloAlf referenced this pull request in AngheloAlf/oot Aug 23, 2021
playerskel pushed a commit to playerskel/oot that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants