Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies and fixed compatibility to ghc-7.10.1 #7

Merged
merged 9 commits into from
Jun 29, 2015
Merged

Updated dependencies and fixed compatibility to ghc-7.10.1 #7

merged 9 commits into from
Jun 29, 2015

Conversation

achirkin
Copy link
Contributor

Tried to use geojson with latest ghc and ran into several compatibility issues.
Suggest these changes to make it work with GHC 7.10.1

@domdere
Copy link
Collaborator

domdere commented Jun 23, 2015

Hmm that travis file looks pretty old, i'll update it to setup a proper environment

@domdere
Copy link
Collaborator

domdere commented Jun 23, 2015

can you rebase please and see how the 7.10.1 travis build goes pls?

@achirkin
Copy link
Contributor Author

Thanks for such quick response! Rebased.

@domdere
Copy link
Collaborator

domdere commented Jun 24, 2015

ok, the head build passes even thought the 7.10.1 build fails... I have to look into that haskell-src-exts problem and see if its an issue with the PR or the travis environment, oes the build work for you from a clean 7.10 environment?

the 7.8 build is broken though, I have been putting off how I want to handle this, I dont really want macros all over the code. Since the code itself has been pretty stable, i am thinking of doing one final cut for 7.8 with the latest deps that will build, before doing a major point release where 7.8 support is dropped.

once i've put that out, and I know the 7.10 build issue isnt a problem with this PR, i'm happy to merge this in as it is and tweak the travis file accordingly

@achirkin
Copy link
Contributor Author

But it should not be so bad. On 7.10.1 there is a problem of haskell-src-exts package, I will request change on this too.
In 7.10.1 Foldable toList moved into class itself, and I forgot about that. I call toList now qualified and I hope it compiles on both platforms.

@domdere
Copy link
Collaborator

domdere commented Jun 24, 2015

Nice those build errors look pretty trivial

@achirkin
Copy link
Contributor Author

Yep, now only 7.10.1 fails due to haskell-src-exts-1.16.0.1 .

@achirkin
Copy link
Contributor Author

Oh no, my latest commit with parsing changes went here

@domdere
Copy link
Collaborator

domdere commented Jun 25, 2015

ok cool thanks, ill merge this in later today and make a cut

domdere added a commit that referenced this pull request Jun 29, 2015
Updated dependencies and fixed compatibility to ghc-7.10.1
@domdere domdere merged commit d115d79 into zellige:master Jun 29, 2015
@domdere
Copy link
Collaborator

domdere commented Jun 29, 2015

sorry i took so long, ill make a cut soon

@domdere
Copy link
Collaborator

domdere commented Jun 29, 2015

@achirkin Its been deployed

achirkin pushed a commit to achirkin/hs-geojson that referenced this pull request Nov 26, 2020
Updated dependencies and fixed compatibility to ghc-7.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants